Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docusaurus: README update #33849

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Docusaurus: README update #33849

merged 2 commits into from
Jan 3, 2024

Conversation

natikgadzhi
Copy link
Contributor

Summary

This pull request clarifies how we build the documentation website. No actual code changes, safe to ship once the content feels right.

What's there:

  • General update and structure.
  • Note on relative link checking + full link checking with a github action.
  • Changed GH pages to Vercel.
  • Clarifying contributing standards on link checks.

Why now

I've broken a few links in #33839, and @erohmensing and @evantahler linked me to it, and I'm just trying to clean things up as I learn.

Next Steps

It looks like we have quite a few links that are broken in the CI run.

Some of them are perhaps false positives and we need to clean the exception rules, but some of them are legit 404s (Zoom Marketplace for example). Not the biggest problem in the world, but would be good to grind through.

Copy link

vercel bot commented Dec 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 0:25am

@natikgadzhi natikgadzhi self-assigned this Dec 29, 2023
Copy link
Contributor

Warning

Soft code freeze is in effect until 2024-01-02. Please avoid merging to master. #freedom-and-responsibility

@natikgadzhi natikgadzhi added area/documentation Improvements or additions to documentation team/documentation labels Dec 29, 2023
- General update and structure.
- Note on relative link checking.
- Changed GH pages to Vercel.
@natikgadzhi natikgadzhi force-pushed the natikgadzhi/docs/readme branch from 590ab1d to 6725c2a Compare December 29, 2023 22:53
@octavia-squidington-iii octavia-squidington-iii removed the area/documentation Improvements or additions to documentation label Dec 29, 2023
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fleshing out the docs on docs!

docusaurus/README.md Outdated Show resolved Hide resolved
```bash
yarn start # any changes will automatically be reflected in your browser!
```

## Making Changes
All the content for docs.airbyte.com lives in the `/docs` directory in this repo. All files are
markdown. Make changes or add new files, and you should see them in your browser!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caveat: adding new files and seeing them requires changing the sidebar (thanks for separating out the next section to make it clearer!), so you can't see this with yarn start. I believe if you need to change the sidebar, you have to run build again (unconfirmed)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmm, I'll double check!

docusaurus/README.md Outdated Show resolved Hide resolved
docusaurus/README.md Outdated Show resolved Hide resolved
docusaurus/README.md Outdated Show resolved Hide resolved
docusaurus/README.md Outdated Show resolved Hide resolved
Co-authored-by: Ella Rohm-Ensing <[email protected]>
@natikgadzhi
Copy link
Contributor Author

@erohmensing thank you! ❤️
I'll merge this after the CI runs.

@natikgadzhi natikgadzhi merged commit dbd8cc4 into master Jan 3, 2024
20 checks passed
@natikgadzhi natikgadzhi deleted the natikgadzhi/docs/readme branch January 3, 2024 00:58
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants