Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination bigquery: restrict test concurrency #34387

Closed
wants to merge 2 commits into from

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Jan 19, 2024

(ignore for now, I just want to trigger CI a few times)

I've only managed to repro various transient test failures when running the full test suite - running individual tests has been super reliable. I also haven't found any explicit interference between tests - they're reliably using different namespaces, etc. so... maybe bigquery itself is having issues when we run several concurrent syncs to the same project?

failures I've seen:

  • T+D being skipped (even though the test logs indicate that T+D was executed successfully)
  • raw tables not being populated (even though the sync terminated with exit code 0)
  • dumpFinalRecords returning fewer records than the expected records, but those records are present in bigquery when I query manually

@edgao edgao requested a review from a team as a code owner January 19, 2024 19:18
Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 5:46pm

Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@edgao edgao closed this Jan 24, 2024
@edgao edgao deleted the edgao/bigquery/test branch January 24, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants