Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindi/Fixing no-such-table-error (WIP - for feedback) #35286

Closed
wants to merge 5 commits into from

Conversation

bindipankhudi
Copy link
Contributor

@bindipankhudi bindipankhudi commented Feb 14, 2024

Resolves: airbytehq/PyAirbyte#30

This is a WIP. Would love any feedback on changes and direction of work.

Main updates

  • _processors.py: Added a Check for empty data streams in the process_input_stream method (This is the first way we talked about. Haven't explored the other options yet)
  • test_source_test_fixture.py: Added an empty stream (stream3) to source-test fixtuure and updated relevant tests. Everything is passing except for three tests I have disabled (more on that below)

Note:

  • You will see three tests (which connect to PostGres, and snowflake) are disabled. This is because my terminal is unable to connect to postgres container (even though it's initialized properly).
  • Still have to run whole suite of tests, linting etc.. Once I resolve the above will continue with running other tests.

Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 10:41pm

@CLAassistant
Copy link

CLAassistant commented Feb 14, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ bindipankhudi
❌ Bindi Pankhudi


Bindi Pankhudi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

…eally intend to rebase, reverting

This reverts commit 5305cf3, reversing
changes made to 73614f7.
@bindipankhudi
Copy link
Contributor Author

Did rebase without thinking. The branch changes got too hairy, so moves changes to a new branch, closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment