🐛 Change null cursor value query to not use IIF sql function #35405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
|
we really should think of ways to add tests for all those different flavors of SQL server. This comes just after a community PR about fixing our handling of azure servers. |
stephane-airbyte
approved these changes
Feb 19, 2024
Connector acceptance test is I think the answer. architecture uses an external server and is designed to be a minimal functional pass - a smoke test. The work we need to do is:
|
…s-query-doesnt-run-on-azure-synapse-analytics
octavia-squidington-iii
added
the
area/documentation
|
In the meantime @evantahler , @postamar , @stephane-airbyte can I please ask one of you to merge this PR in to update the beta |
|
/approve-and-merge reason="minor bug fix. CI is still broken" |
|
Our work here is done |
octavia-approvington
approved these changes
Feb 21, 2024
octavia-approvington
deleted the
30642-source-mssql-verifycursorcolumnvalues-query-doesnt-run-on-azure-synapse-analytics
branch
jatinyadav-cc
added a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
* ✨ source-surveymonkey: migrate to poetry (airbytehq#35168) * ✨ source-monday: migrate to poetry (airbytehq#35146) * ✨ source-salesforce: migrate to poetry (airbytehq#35147) * ✨ source-intercom: migrate to poetry (airbytehq#35148) * ✨ source-iterable: migrate to poetry (airbytehq#35150) * ✨ source-mixpanel: migrate to poetry (airbytehq#35151) * ✨ source-typeform: migrate to poetry (airbytehq#35152) * ✨ source-twilio: migrate to poetry (airbytehq#35153) * ✨ source-notion: migrate to poetry (airbytehq#35155) * ✨ source-zendesk-talk: migrate to poetry (airbytehq#35156) * ✨ source-amplitude: migrate to poetry (airbytehq#35162) * ✨ source-jira: migrate to poetry (airbytehq#35160) * ✨ source-google-ads: migrate to poetry (airbytehq#35158) * 🐛 Source Slack: Join to the channels while `read` instead of `discovery` (airbytehq#35131) * ✨ source-hubspot: migrate to poetry (airbytehq#35165) * ✨ source-pinterest: migrate to poetry (airbytehq#35159) * ✨ source-sentry: migrate to poetry (airbytehq#35145) * ✨ source-chargebee: migrate to poetry (airbytehq#35169) * source-snapchat-marketing: adopt our base image (airbytehq#35170) * ✨ source-snapchat-marketing: migrate to poetry (airbytehq#35171) * source-faker: adopt our base image (airbytehq#35172) * ✨ source-faker: migrate to poetry (airbytehq#35174) * ✨ source-amazon-ads: migrate to poetry (airbytehq#35180) * Source Github: add integration tests (airbytehq#34933) * ✨ source-bing-ads: migrate to poetry (airbytehq#35179) * ✨ source-instagram: migrate to poetry (airbytehq#35177) * ✨ source-facebook-marketing: migrate to poetry (airbytehq#35178) * destination-async-framework: make emission of state from FlushWorkers synchronized (airbytehq#35144) * ✨ source-freshdesk: migrate to poetry (airbytehq#35187) * 🐛 source-mysql Support special chars in dbname (airbytehq#34580) * AirbyteLib: Release 0.1.0 (airbytehq#35184) * 📚 Adjust documentation for corepack (airbytehq#35192) * ✨ source-recharge: migrate to poetry (airbytehq#35182) * ✨ source-tiktok-marketing: migrate to poetry (airbytehq#35161) * Bump Airbyte version from 0.50.48 to 0.50.49 * ✨ Destination Postgres: DV2 GA (airbytehq#35042) Co-authored-by: Marius Posta <[email protected]> Co-authored-by: Evan Tahler <[email protected]> * Destination snowflake: reorder auth spec options (airbytehq#35194) * ✨ source-zendesk-chat: migrate to poetry (airbytehq#35185) * ✨ source-sendgrid: migrate to poetry (airbytehq#35181) * ✨ source-gitlab: migrate to poetry (airbytehq#35167) * ✨ source-airtable: migrate to poetry (airbytehq#35149) * ✨ source-google-search-console: migrate to poetry (airbytehq#35163) * 🐛Source Amazon Seller Partner: add integration tests (airbytehq#33996) * ✨ source-s3: migrate to poetry (airbytehq#35164) * ✨ source-shopify: migrate to poetry (airbytehq#35166) * ✨ source-file: migrate to poetry (airbytehq#35186) * ✨ source-slack: migrate to poetry (airbytehq#35157) * ✨ source-harvest: migrate to poetry (airbytehq#35154) * Source Chargebee: Updates schemas for validation and missing fields errors, updates test bypass, adds expected records, adds custom error handling, adds incremental support for three streams (airbytehq#34053) * Don't emit final state if there is an underlying stream failure (airbytehq#34869) Co-authored-by: Xiaohan Song <[email protected]> * Remove IAM Role Setup instructions from s3.md (airbytehq#35190) * Bump Airbyte version from 0.50.49 to 0.50.50 * airbyte-ci: run `poetry check` before `poetry install` on poetry package install (airbytehq#35212) * ✨ Source File: add fixed width file format support (airbytehq#34678) Co-authored-by: mgreene <[email protected]> Co-authored-by: Serhii Lazebnyi <[email protected]> Co-authored-by: Serhii Lazebnyi <[email protected]> * source-postgres: adopt CDK 0.20.4 (airbytehq#35224) * 🐛 Set cdc record subsequent record wait time to initial wait time as a workaround (airbytehq#35114) * AirbyteLib: docs: add Colab quicklink (airbytehq#35215) * AirbyteLib: support secrets in dotenv files (airbytehq#35244) * Add airbyte trace utility to emit analytics messages & emit messages for MongoDB, Postgres & MySQL (airbytehq#35036) * AirbyteLib: Docs: fix colab badge (airbytehq#35248) * AirbyteLib: improve json schema type detection (airbytehq#35263) * 🏥 Source Mixpanel: update stream Funnels with custom_event_id and custom_event fields fields (airbytehq#35203) * write logs to file in addition to stdout when running java connector tests (airbytehq#35236) * destination-duckdb: remove superfluous build.gradle file (airbytehq#35277) * fix `:airbyte-integrations:connectors:destination-duckdb' could not be found in project` (airbytehq#35279) * destination-e2e-test,dev-null: use CDK 0.20.6 (airbytehq#35278) * AirbyteLib: Add support for JSON and VARIANT types (airbytehq#35117) Co-authored-by: Joe Reuter <[email protected]> * Docs: add deprecation note for normalization and custom transformation (airbytehq#35275) * 🎉 Source Intercom: Update the API Version to `2.10` (airbytehq#35176) * 🐛 Source Harvest: Revert poetry update (airbytehq#35296) * AirbyteLib: Mark and deprioritize slow tests (airbytehq#35298) * source-clickhouse: adopt CDK 0.20.4 (airbytehq#35235) * source-cockroachdb: adopt CDK 0.20.4 (airbytehq#35234) * source-db2: adopt CDK 0.20.4 (airbytehq#35233) * source-dynamodb: adopt CDK 0.20.4 (airbytehq#35232) * source-e2e-test: adopt CDK 0.20.4 (airbytehq#35231) * source-elasticsearch: adopt CDK 0.20.4 (airbytehq#35230) * source-kafka: adopt CDK 0.20.4 (airbytehq#35229) * source-oracle: adopt CDK 0.20.4 (airbytehq#35225) * source-redshift: adopt CDK 0.20.4 (airbytehq#35223) * source-scaffold-java-jdbc: adopt CDK 0.20.4 (airbytehq#35222) * source-sftp: adopt CDK 0.20.4 (airbytehq#35221) * source-snowflake: adopt CDK 0.20.4 (airbytehq#35220) * source-teradata: adopt CDK 0.20.4 (airbytehq#35219) * source-tidb: adopt CDK 0.20.4 (airbytehq#35218) * Throw cdc cursor error * Revert bad commit * AirbyteLib: suppress duckdb reflection warnings (airbytehq#35300) * Source Google Ads: temporary patch to avoid 500 Internal server error (airbytehq#35280) * 🐛 python cdk: mask oauth access key (airbytehq#34931) * 🤖 Bump patch version of Python CDK * Emit multiple error trace messages and continue syncs by default (airbytehq#35129) * 🤖 Bump minor version of Python CDK * ✨Source Amazon Seller Partner: add `VendorOrders` stream (airbytehq#35273) * File-based CDK: enqueue AirbyteMessage of type record instead of sending to the message repository (airbytehq#35318) * 🤖 Bump patch version of Python CDK * 🚨🚨🐛 Source Gitlab fix merge_request_commits stream (airbytehq#34548) * java CDK: improve blobstore module structure (airbytehq#35285) * source-mysql: add and adopt TestDatabaseWithInvalidDatabaseName (airbytehq#35210) * ✨ Source File: support ZIP file (airbytehq#32354) Co-authored-by: Serhii Lazebnyi <[email protected]> Co-authored-by: Serhii Lazebnyi <[email protected]> * destination-async-framework: move the state emission logic into GlobalAsyncStateManager (airbytehq#35240) * 🐛 Source Harvest: Fix pendulum parsing error (airbytehq#35305) Co-authored-by: Christo Grabowski <[email protected]> * ✨ Source GitHub: updating branches schema and unpin on cloud (airbytehq#35271) Co-authored-by: maxi297 <[email protected]> Co-authored-by: Maxime Carbonneau-Leclerc <[email protected]> * AirbyteLib: Fix no-such-table-error (airbytehq#35311) Co-authored-by: Bindi Pankhudi <[email protected]> Co-authored-by: Aaron Steers <[email protected]> * 📝 add instructions for soft reset (airbytehq#35335) * [source-postgres] Add test for legacy version of postgres (airbytehq#35329) * Source Klaviyo: added transform config for profile stream (airbytehq#35336) * 🏥 Source Hubspot: updated marketing emails schema and expected records (airbytehq#35328) * gradle: split off python cdk (airbytehq#35306) * gradle: overall simplification (airbytehq#35307) * docs: typos (airbytehq#35302) * Docs: Update stripe.md (airbytehq#35142) * Test PR to check Slack notifications (airbytehq#35363) * airbyte-ci: remove reference to buildConnectorImage (airbytehq#35364) * Source S3: revert rollback to 4.4.1 (airbytehq#35055) Co-authored-by: Augustin <[email protected]> * 🐛 Source OpsGenie: fix parsing of updated_at timestamps from OpsGenie (airbytehq#35269) Co-authored-by: marcosmarxm <[email protected]> * Archive `destination-kvdb` (airbytehq#35370) * Add `archived` as connector support level (airbytehq#35355) * Remove `octavia-cli` (airbytehq#33950) * Docs: update k8s instructions for upgrade (airbytehq#35108) * Destination redshift: delete some unused files (airbytehq#35314) * re-add destination-kvdb as archived connector (airbytehq#35377) * destination-kvdb - publish for real (airbytehq#35379) * Support user-specified test read limits in `connector_builder` code (airbytehq#35312) * 🤖 Bump patch version of Python CDK * destination-kvdb bump to publish (airbytehq#35381) * ✨ Source Paypal Transactions: Siver Certification (airbytehq#34510) Co-authored-by: Alexandre Girard <[email protected]> Co-authored-by: alafanechere <[email protected]> Co-authored-by: Augustin <[email protected]> * Revamp QA checks into a battery included package (airbytehq#35322) * 🏥 Source Pinterest: updated expected records (airbytehq#35353) * .github: fix python CDK publish (airbytehq#35391) * 🐛 Source Amazon Seller Partner: Fix check for Vendor accounts (airbytehq#35331) * doc: Document our connectors QA checks (airbytehq#35324) * airbyte-ci: use connectors-qa instead of connector_ops.qa_check (airbytehq#35325) * Update `metadata-service` to latest version + docs (airbytehq#35419) * Bump destination-kvdb again to test metadata for archival (airbytehq#35422) * connectors_qa: make `CheckPublishToPyPiIsEnabled` only run on source connectors (airbytehq#35426) * gradle: remove archived connectors (airbytehq#35423) * ✨Source Facebook Marketing: add integration tests (airbytehq#35061) * Delete `requirements.txt` on poetry managed connectors (airbytehq#35406) * update doc to reference poetry (airbytehq#35414) * 🧹 remove qa_checks.py (airbytehq#35434) * connectors-qa: fix connector type attribute access (airbytehq#35435) * java-connectors: add thread name as part of the log message (airbytehq#35199) * doc: remove Node requirements on config based getting started tutorial (airbytehq#35436) * airbyte-ci: disable telemetry with env var (airbytehq#35438) * airbyte-ci: disable a flaky test (airbytehq#35418) * ci: check for required reviewers on destinations (airbytehq#35428) * destination-kvdb QA checks (airbytehq#35424) Co-authored-by: Augustin <[email protected]> * Add destination-kvdb to OSS registry (airbytehq#35444) * Normalization logs: remove json parse warnings (airbytehq#34978) * Support archived connectors in Docs (airbytehq#35374) * remove destination-kvdb one more time (airbytehq#35382) * [Source-Postgres] : Add config to throw an error on invalid CDC position (airbytehq#35304) * java-cdk:remove unused class (airbytehq#35408) * Source S3: add filter by start date (airbytehq#35392) * Revert "Add destination-kvdb to OSS registry" (airbytehq#35453) * airbyte-ci: do no run QA checks on publish - only MetadataValidation (airbytehq#35437) Co-authored-by: Ella Rohm-Ensing <[email protected]> * restore kvdb to state from airbytehq#35424 (airbytehq#35454) * 🚨🚨 Source Facebook Marketing: Add statuses filters (airbytehq#32449) Co-authored-by: Anatolii Yatsuk <[email protected]> * add proper logging to junit runs (airbytehq#35394) Basically, Junit is not logging any thing about its progress outside of the console. This is aimed at fixing that by outputing progress logs along with the standard logs. So there's going to be a line before each step of a test run, and a line after with the elapsed time. Also, exception are now part of the logs instead of being only part of the junit report. In the process of doing that, I decided to clean up and simplify the log4j2.xml file. I also noted a few issues with ANSI coloring, so there's a fix for that. Finally, I'm removing empty lines from container logs (MSSQL is full of them). The junit printing is done through an intereceptor. That interceptor uses introspection. I wanted to use a factory method, but java's ServiceLoader only allows classes that extends the service interface, hence the need to override every method in the interceptor class, and to plop a proxy on top of that. * Re-ignore documentation structure check for the time being (airbytehq#35458) * [Source-mysql] : Add config to throw an error on invalid CDC position (airbytehq#35338) * [Source-Mongodb] : Add config to throw an error on invalid CDC position (airbytehq#35375) * pin to older version (airbytehq#35469) * Update on-kubernetes-via-helm.md - Add GCS Logging steps (airbytehq#35455) Co-authored-by: Sajarin <[email protected]> * Airbyte CDK: add filter to RemoveFields (airbytehq#35326) Signed-off-by: Artem Inzhyyants <[email protected]> * 🤖 Bump minor version of Python CDK * 🐛 Source Facebook Marketing: Fix error during transforming state (airbytehq#35467) * .github: remove connector checklist (airbytehq#35484) * connectors_qa: bump to 1.0.3 (airbytehq#35475) * .github: tighter filtering for gradle workflow (airbytehq#35492) * Airbyte docs: Fixed JSON schema rendering issues for dark mode (airbytehq#35489) Co-authored-by: bindipankhudi <[email protected]> * Source Quickbooks: fix spec (airbytehq#35457) * 🐛 Change null cursor value query to not use IIF sql function (airbytehq#35405) * Source Google Ads: rollback patch 500 Internal Server Error (airbytehq#35493) * Fix syntax error in `tools/bin/manage.sh`, used to publish airbyte cdk (airbytehq#35466) * [DB sources] : Reduce CDC state compression limit to 1MB (airbytehq#35511) * 🤖 Bump patch version of Python CDK * Add ignore_stream_slicer_parameters_on_paginated_requests flag (airbytehq#35462) * 🤖 Bump minor version of Python CDK * Mangle unhandled MongoCommandException to prevent creating grouping o… (airbytehq#35526) * .github: fix java cdk publish workflow (airbytehq#35533) * [Source-mysql] : Adopt 0.21.4 and reduce cdc state compression threshold to 1MB (airbytehq#35525) * 🏥 Source Notion: update stream schema (airbytehq#35409) * airbyte-ci: make QA check work on strict-encrypt connectors (airbytehq#35536) * Update docs to show archived information if connector is not in registries (airbytehq#35468) * 🐛 Source Facebook Marketing: Add missing config migration (airbytehq#35539) * docs: update ALB configuration docs for exposing API (airbytehq#35520) * chore: remove upgrading-airbyte.md (airbytehq#35545) * 📚 Add documentation for Entra ID (airbytehq#34569) * Bump Airbyte version from 0.50.50 to 0.50.51 * gradle.yml: use a smaller runner (airbytehq#35547) * airbyte-ci: augment the report for java connectors (airbytehq#35317) Today we're missing the logs (both JVM and container logs) in java connector reports. This is creating a link to test artifacts. In the CI, the link will point to a zip file, while on a local run, it will point to a directory. In addition, we recently added the junit XML inlined with the test standard output and error, but that didn't really work as well as we'd hoped: The reports were slow to load, they were not ordered by time, the corresponding logs were lacking. There's still a possibility they'll be useful, so rather than removing them altogether, they will be bundled in the log zip (or directory). I'm also adding a button to copy the standard output or the standard error from a step into the clipboard. Finally, I'm reducing the max vertical size of an expanded step, so it doesn't go over 70%, which seems much cleaner to me. Here's an example of the result (from the child PR): https://storage.cloud.google.com/airbyte-ci-reports-multi/airbyte-ci/connectors/test/pull_request/stephane_02-09-add_background_thread_to_track_mssql_container_status/1708056420/d4683bfb7f90675c6b9e7c6d4bbad3f98c7a7550/source-mssql/3.7.0/output.html * Source SalesForce: Add Stream Slice Step option to specification (airbytehq#35421) Signed-off-by: Artem Inzhyyants <[email protected]> * Destination Clickhouse - 1.0, remove normalization (airbytehq#34637) Co-authored-by: Aaron ("AJ") Steers <[email protected]> Co-authored-by: Joe Reuter <[email protected]> Co-authored-by: Obioma Anomnachi <[email protected]> Co-authored-by: Anatolii Yatsuk <[email protected]> Co-authored-by: Maxime Carbonneau-Leclerc <[email protected]> Co-authored-by: maxi297 <[email protected]> Co-authored-by: Ryan Waskewich <[email protected]> Co-authored-by: Catherine Noll <[email protected]> Co-authored-by: Marius Posta <[email protected]> Co-authored-by: Edward Gao <[email protected]> Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: SatishChGit <[email protected]> Co-authored-by: evantahler <[email protected]> Co-authored-by: Rodi Reich Zilberman <[email protected]> Co-authored-by: Anton Karpets <[email protected]> Co-authored-by: Christo Grabowski <[email protected]> Co-authored-by: Akash Kulkarni <[email protected]> Co-authored-by: Akash Kulkarni <[email protected]> Co-authored-by: Gireesh Sreepathi <[email protected]> Co-authored-by: Artem Inzhyyants <[email protected]> * Airbyte CDK: add interpolation for request options (airbytehq#35485) Signed-off-by: Artem Inzhyyants <[email protected]> Co-authored-by: Alexandre Girard <[email protected]> * 🤖 Bump minor version of Python CDK * Handle seeing uncompressed sendgrid contact data (airbytehq#35343) * gradle.yml: use XXL runners but only if gradle related files are changed (airbytehq#35548) * ✨ [greenhouse] [iterable] [linkedin-ads] [paypal-transactions] [pinterest] Bump cdk versions for to use continue on stream per-error reporting (airbytehq#35465) * Airbyte CDK: add CustomRecordFilter (airbytehq#35283) Signed-off-by: Artem Inzhyyants <[email protected]> * 🤖 Bump minor version of Python CDK * Do not add connector header to source and destination index pages (airbytehq#35553) * gradle.yml: fix path filters (airbytehq#35554) * Source Monday: fix gql query to support inline fragment value for the Items stream (airbytehq#35506) * gradle.yml: checkout the repo when not PR trigger (airbytehq#35558) * airbyte-cdk [python]: re-enable tests in CI (airbytehq#35560) Co-authored-by: Marius Posta <[email protected]> * ✨ [source-mssql] skip sql server agent check if EngineEdition == 8 (airbytehq#35368) * push new source-mssql version (airbytehq#35564) * Destinations CDK: Refactor T+D to gather required world state upfront (airbytehq#35342) Signed-off-by: Gireesh Sreepathi <[email protected]> * .github: fix python_cdk_tests.yml (airbytehq#35567) * Bump Airbyte version from 0.50.51 to 0.50.52 * add entry into JAVA_OPTS to always select log4j2.xml as our logger configuration (airbytehq#35569) * destination-s3: bump patch version following airbytehq#35569 (airbytehq#35576) Co-authored-by: Stephane Geneix <[email protected]> * destination-snowflake: bump patch version following airbytehq#35569 (airbytehq#35575) Co-authored-by: Stephane Geneix <[email protected]> * destination-bigquery: bump patch version following airbytehq#35569 (airbytehq#35574) Co-authored-by: Stephane Geneix <[email protected]> * source-mysql: bump patch version following airbytehq#35569 (airbytehq#35573) Co-authored-by: Stephane Geneix <[email protected]> * source-postgres: bump patch version following airbytehq#35569 (airbytehq#35572) Co-authored-by: Stephane Geneix <[email protected]> * source-mongodb-v2: bump patch version following airbytehq#35569 (airbytehq#35571) Co-authored-by: Stephane Geneix <[email protected]> * airbyte-ci-test.yml: only run if modified internal poetry packages (airbytehq#35551) * airbyte-ci-test.yml: checkout repo for path filters when not on PR (airbytehq#35577) * connectors-ci: early exit when no connector changes (airbytehq#35578) * Microsoft Entra ID for Self-Managed Enterprise (airbytehq#35585) * Improve documentation on check command (airbytehq#35542) Co-authored-by: Ella Rohm-Ensing <[email protected]> * 🐛 Source S3: fix exception when setting CSV stream delimiter to `\t`. (airbytehq#35246) Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: marcosmarxm <[email protected]> * 🐛 Source BigQuery: fix error with RECORD REPEATED fields (airbytehq#35503) Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: marcosmarxm <[email protected]> * re-release source mssql with logger fixes (airbytehq#35596) * Source File: change header=0 to header=null in docs (airbytehq#35595) CI tests failed because the version was not incremented, despite only a single line being altered in the documentation. This change is minor and can be safely merged. * Changed tag to low code (airbytehq#35594) CI tests failed because the version was not incremented. This change is minor and can be safely merged. * Bump Airbyte version from 0.50.52 to 0.50.53 * Destination Postgres: CDK T+D initial state gathering (airbytehq#35385) Signed-off-by: Gireesh Sreepathi <[email protected]> * Destination Snowflake: CDK T+D initial state refactor (airbytehq#35456) Signed-off-by: Gireesh Sreepathi <[email protected]> * Destination Redshift: CDK T+D initial state refactor (airbytehq#35354) Signed-off-by: Gireesh Sreepathi <[email protected]> * delete metadata checks workflow (airbytehq#35580) * Source Recurly: Enable in registries with updated CDK (airbytehq#34622) * reduce interrupt and shutdown delays to 1 minutes and 2 minutes when stopping a connector (initially set at 60minutes and 70minutes) (airbytehq#35527) Fixes airbytehq#32348 discussed here : https://airbytehq-team.slack.com/archives/C02U2SSHP9S/p1708552465201999 * Docs: Add depecration notices to sunsetting connectors (airbytehq#35446) * Cleaned up PyAibyte docs (PR # 35603) (airbytehq#35603) Co-authored-by: bindipankhudi <[email protected]> * Source S3: run incremental syncs with concurrency (airbytehq#34895) * old commits added * add file location in output stream * file docker file * docker file version change * pgp docker file * fix * Bump gnupg version and pgp decryption changes * fix bug * fix: discover dtype issued and test cases added * added files --------- Signed-off-by: Artem Inzhyyants <[email protected]> Signed-off-by: Gireesh Sreepathi <[email protected]> Co-authored-by: Augustin <[email protected]> Co-authored-by: Baz <[email protected]> Co-authored-by: Artem Inzhyyants <[email protected]> Co-authored-by: Subodh Kant Chaturvedi <[email protected]> Co-authored-by: Xiaohan Song <[email protected]> Co-authored-by: Aaron ("AJ") Steers <[email protected]> Co-authored-by: Tim Roes <[email protected]> Co-authored-by: benmoriceau <[email protected]> Co-authored-by: Gireesh Sreepathi <[email protected]> Co-authored-by: Marius Posta <[email protected]> Co-authored-by: Evan Tahler <[email protected]> Co-authored-by: Edward Gao <[email protected]> Co-authored-by: Anton Karpets <[email protected]> Co-authored-by: Patrick Nilan <[email protected]> Co-authored-by: Akash Kulkarni <[email protected]> Co-authored-by: Tyler B <[email protected]> Co-authored-by: bgroff <[email protected]> Co-authored-by: mjgatz <[email protected]> Co-authored-by: mgreene <[email protected]> Co-authored-by: Serhii Lazebnyi <[email protected]> Co-authored-by: Serhii Lazebnyi <[email protected]> Co-authored-by: Rodi Reich Zilberman <[email protected]> Co-authored-by: Daryna Ishchenko <[email protected]> Co-authored-by: Stephane Geneix <[email protected]> Co-authored-by: Joe Reuter <[email protected]> Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: Maxime Carbonneau-Leclerc <[email protected]> Co-authored-by: Akash Kulkarni <[email protected]> Co-authored-by: Roman Yermilov [GL] <[email protected]> Co-authored-by: Alexandre Girard <[email protected]> Co-authored-by: girarda <[email protected]> Co-authored-by: Brian Lai <[email protected]> Co-authored-by: brianjlai <[email protected]> Co-authored-by: Catherine Noll <[email protected]> Co-authored-by: midavadim <[email protected]> Co-authored-by: Julien COUTAND <[email protected]> Co-authored-by: Christo Grabowski <[email protected]> Co-authored-by: maxi297 <[email protected]> Co-authored-by: Bindi Pankhudi <[email protected]> Co-authored-by: Bindi Pankhudi <[email protected]> Co-authored-by: Ben Drucker <[email protected]> Co-authored-by: TornadoContre <[email protected]> Co-authored-by: Natik Gadzhi <[email protected]> Co-authored-by: Thomas Dippel <[email protected]> Co-authored-by: marcosmarxm <[email protected]> Co-authored-by: Alex Birdsall <[email protected]> Co-authored-by: ambirdsall <[email protected]> Co-authored-by: Jose Gerardo Pineda <[email protected]> Co-authored-by: alafanechere <[email protected]> Co-authored-by: Anatolii Yatsuk <[email protected]> Co-authored-by: Pedro S. Lopez <[email protected]> Co-authored-by: Ella Rohm-Ensing <[email protected]> Co-authored-by: Siarhei Ivanou <[email protected]> Co-authored-by: Anatolii Yatsuk <[email protected]> Co-authored-by: Ryan Waskewich <[email protected]> Co-authored-by: Sajarin <[email protected]> Co-authored-by: artem1205 <[email protected]> Co-authored-by: perangel <[email protected]> Co-authored-by: Joe Bell <[email protected]> Co-authored-by: Obioma Anomnachi <[email protected]> Co-authored-by: maxi297 <[email protected]> Co-authored-by: SatishChGit <[email protected]> Co-authored-by: Brian Leonard <[email protected]> Co-authored-by: David Wallace <[email protected]> Co-authored-by: pmossman <[email protected]> Co-authored-by: Stephane Geneix <[email protected]> Co-authored-by: Alexandre Cuoci <[email protected]> Co-authored-by: Danny Tiesling <[email protected]> Co-authored-by: Marco Fontana <[email protected]> Co-authored-by: rishabh-cldcvr <[email protected]>
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Our null cursor value query is using the
IIFsql function that is not available on Azure Synapse Analytics sql servers (see https://learn.microsoft.com/en-us/sql/t-sql/functions/logical-functions-iif-transact-sql?view=sql-server-ver16#remarks)This PR changes the query to use a simpler sql avoiding this command.
How
Edit the null cursor value query to syntax that is acceptable by all sql servers.