Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨🚨✨ Source Facebook Pages: Upgrade Facebook API to v19.0 #36015

Merged
merged 10 commits into from
Mar 18, 2024

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Mar 13, 2024

What

Upgrade API to v19.0. This PR incorporates contributor changes: #35433

🚨 User Impact 🚨

Schema breaking change for stream page.

Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
airbyte-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Mar 18, 2024 3:39pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-pages labels Mar 13, 2024
@tolik0 tolik0 marked this pull request as ready for review March 14, 2024 13:14
@tolik0 tolik0 changed the title ✨ Source Facebook Pages: Upgrade Facebook API to v19.0 🚨🚨✨ Source Facebook Pages: Upgrade Facebook API to v19.0 Mar 14, 2024
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 14, 2024 13:16
@tolik0 tolik0 requested a review from a team March 14, 2024 13:16
## Upgrading to 1.0.0

:::note
This change is only breaking if you are syncing stream `page`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to tell them what fields are disappearing. or if any of them are being replaced with a different name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

breakingChanges:
1.0.0:
message: >-
This version updates the API version from v15 to v19. Deprecated fields have been removed and new fields have been added for the stream `page`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 18, 2024 12:50
This change is only breaking if you are syncing stream `Page`.
:::

This version brings an updated schema for the `v19.0` API version of the `Page` stream. The `messenger_ads_default_page_welcome_message` field has been deleted, and a few new fields have been added.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please specify what's been added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 18, 2024 15:30
@tolik0 tolik0 merged commit e8c51cb into master Mar 18, 2024
32 checks passed
@tolik0 tolik0 deleted the tolik0/source-facebook-pages/migrate-api-to-v19 branch March 18, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants