Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Mixpanel low code migration #36724
🎉 Source Mixpanel low code migration #36724
Changes from all commits
492dfe4
0ba0485
f64abec
672d7fc
b931bc2
95a220a
3f223b1
6786628
dc28438
38ff0e7
e628c0b
ee81cbd
b6095c2
43a620b
a52051f
2b8e9dc
9f7f29a
554ea83
2d12e72
ed70354
32954f2
9f31d43
2d43bc4
5ffaa96
3c6978d
fddbd47
4f0aab7
e4f6911
159c023
70a7edd
52fcc67
ac896dc
1e03761
752a925
9dbdc41
ed162c8
a81c117
3ca9583
eaae7d1
d0df96b
bad3e16
65ddbc7
980f593
77ff468
1df4398
d9f7b90
d9972f6
c93faf4
b49aeb2
7a3e613
fe17df1
6cd1009
0de9682
3a897d4
fecb825
3fb1860
776250f
e37672f
e510be1
92655a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could methods
get_url_base
andget_request_params
be moved to themanifest
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_url_base moved to manifest
get_request_params should be declared here because is the issue: #38021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible the values aren't passed because the fields are not defined on the custom requester? The fields must be defined as dataclass params to be accessible. Here's the doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what exactly goes wrong but I just add request_parameters/request_headers and they do not work: