Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAT: fix incremental by running tests per stream #36814

Merged
merged 21 commits into from
Jun 3, 2024
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4cfe937
CAT: fix incremental by running tests per stream
roman-yermilov-gl Apr 3, 2024
bdca1d9
CAT: add checkpointing strategy configuration
roman-yermilov-gl Apr 4, 2024
b4e36a8
Merge branch 'master' into ryermilov/cat-fix-incremental-test
roman-yermilov-gl May 2, 2024
7e0b0e8
CAT incremental fixes:
roman-yermilov-gl May 2, 2024
bb3719c
fix code format
roman-yermilov-gl May 2, 2024
c07fb92
Merge branch 'master' into ryermilov/cat-fix-incremental-test
roman-yermilov-gl May 10, 2024
f1aa3b9
Merge branch 'master' into ryermilov/cat-fix-incremental-test
roman-yermilov-gl May 17, 2024
6bbba5c
Merge branch 'master' into ryermilov/cat-fix-incremental-test
roman-yermilov-gl May 22, 2024
bb1f9a9
Select unique test messages based on record count
roman-yermilov-gl May 23, 2024
9be4fa0
Merge branch 'master' into ryermilov/cat-fix-incremental-test
roman-yermilov-gl May 23, 2024
f408169
refactoring
roman-yermilov-gl May 29, 2024
754b116
Merge branch 'master' into ryermilov/cat-fix-incremental-test
roman-yermilov-gl May 29, 2024
4621c91
format code
roman-yermilov-gl May 29, 2024
cc35459
simplify implementation
roman-yermilov-gl May 29, 2024
2562b3f
fix format
roman-yermilov-gl May 29, 2024
3da7370
Merge branch 'master' into ryermilov/cat-fix-incremental-test
roman-yermilov-gl May 29, 2024
f09ac46
fix run for latest state
roman-yermilov-gl May 30, 2024
391a8cb
fix latest state unique handler
roman-yermilov-gl May 30, 2024
e9043b5
fix latest state unique handler
roman-yermilov-gl May 30, 2024
8b09325
format code
roman-yermilov-gl May 30, 2024
6900de5
Merge branch 'master' into ryermilov/cat-fix-incremental-test
roman-yermilov-gl May 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,27 @@ class FutureStateConfig(BaseConfig):
bypass_reason: Optional[str]


class CheckpointingStrategies(str, Enum):
girarda marked this conversation as resolved.
Show resolved Hide resolved
use_state_variation = "use_state_variation"
use_latest_state = "use_latest_state"


class CheckpointingStrategyPerStreamConfiguration(BaseConfig):
name: str
strategy: CheckpointingStrategies = Field(
description="Depending on the stream configuration and the amount of data, we can select a strategy for testing state progression."
)


class CheckpointingStrategyConfiguration(BaseConfig):
strategy: CheckpointingStrategies = Field(
default=CheckpointingStrategies.use_state_variation, description="Define what state to use during test checkpointing."
)
streams: List[CheckpointingStrategyPerStreamConfiguration] = Field(
default_factory=list, description="Define what state to use during test checkpointing per stream."
)


class IncrementalConfig(BaseConfig):
config_path: str = config_path
configured_catalog_path: Optional[str] = configured_catalog_path
Expand All @@ -212,6 +233,15 @@ class IncrementalConfig(BaseConfig):
skip_comprehensive_incremental_tests: Optional[bool] = Field(
description="Determines whether to skip more granular testing for incremental syncs", default=False
)
checkpointing_strategy: CheckpointingStrategyConfiguration = Field(
default_factory=CheckpointingStrategyConfiguration,
description=(
"Select a strategy for testing connector checkpointing. "
"There are two available options: we can decide whether to use only the last state message or more. "
"When selecting `use_state_variation`, it's important to note that in order to prevent spamming APIs, "
"we test only a subset of batches, excluding the first and last states to mitigate potential corner cases."
),
)

class Config:
smart_union = True
Expand Down
Loading
Loading