Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove calls to java stream() #37539

Merged
merged 1 commit into from
May 23, 2024
Merged

remove calls to java stream() #37539

merged 1 commit into from
May 23, 2024

Conversation

stephane-airbyte
Copy link
Contributor

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

This was referenced Apr 24, 2024
Merged
Merged
@vercel Vercel
Copy link

vercel bot commented Apr 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 6:13pm

@stephane-airbyte stephane-airbyte mentioned this pull request Apr 24, 2024
Merged
2 tasks
@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented Apr 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte stephane-airbyte mentioned this pull request Apr 24, 2024
Merged
2 tasks
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Apr 24, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from e9c6e0b to 8e1fa10 Compare April 24, 2024 15:08
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_calls_to_java_stream_ branch from 51f0f84 to 6f29c47 Compare April 24, 2024 15:08
stephane-airbyte
stephane-airbyte commented Apr 24, 2024
View reviewed changes
...cdk/core/src/testFixtures/kotlin/io/airbyte/cdk/integrations/base/ssh/SshBastionContainer.kt
@@ -144,13 +144,8 @@ class SshBastionContainer : AutoCloseable {
*/
fun getInnerContainerAddress(container: Container<*>): ImmutablePair<String, Int> {
return ImmutablePair.of(
container.containerInfo.networkSettings.networks.entries
.stream()
.findFirst()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

findFirst().get().value would throw an exception if the stream is empty. first() throws an exception if the stream is empty.

@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_calls_to_java_stream_ branch from 6f29c47 to 7214dad Compare April 24, 2024 15:48
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from 8e1fa10 to 94b3f5f Compare April 24, 2024 16:21
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_calls_to_java_stream_ branch from 7214dad to 7c8644f Compare April 24, 2024 16:21
@stephane-airbyte stephane-airbyte mentioned this pull request Apr 24, 2024
Merged
2 tasks
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_calls_to_java_stream_ branch from 7c8644f to 871b988 Compare April 24, 2024 22:44
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from 94b3f5f to f4993cd Compare April 25, 2024 00:13
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_calls_to_java_stream_ branch from 871b988 to 741c4e0 Compare April 25, 2024 00:13
@stephane-airbyte stephane-airbyte mentioned this pull request Apr 25, 2024
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from f4993cd to 40ec450 Compare May 22, 2024 18:53
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_calls_to_java_stream_ branch from 741c4e0 to c973ec7 Compare May 22, 2024 18:53
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from 40ec450 to dff0e27 Compare May 22, 2024 19:52
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_calls_to_java_stream_ branch from c973ec7 to ce051da Compare May 22, 2024 19:53
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from dff0e27 to f511458 Compare May 22, 2024 20:12
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_calls_to_java_stream_ branch from ce051da to cf6216b Compare May 22, 2024 20:12
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from f511458 to bc2e1f5 Compare May 22, 2024 20:56
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_calls_to_java_stream_ branch from cf6216b to bc2ce57 Compare May 22, 2024 20:56
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from bc2e1f5 to e9bd2b1 Compare May 22, 2024 21:45
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_calls_to_java_stream_ branch from bc2ce57 to 7b8866f Compare May 22, 2024 21:45
@stephane-airbyte stephane-airbyte mentioned this pull request May 22, 2024
Merged
2 tasks
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from e9bd2b1 to b3838ee Compare May 22, 2024 22:35
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from b3838ee to 2ba1799 Compare May 22, 2024 22:51
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_calls_to_java_stream_ branch from 6c67ee9 to 2134e41 Compare May 22, 2024 22:51
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from 2ba1799 to e80c347 Compare May 22, 2024 23:10
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_calls_to_java_stream_ branch from 2134e41 to 3c1eed3 Compare May 22, 2024 23:10
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from e80c347 to c870a2c Compare May 22, 2024 23:45
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_calls_to_java_stream_ branch 3 times, most recently from e2be9c5 to 86bc96e Compare May 23, 2024 03:53
@stephane-airbyte stephane-airbyte marked this pull request as ready for review May 23, 2024 05:34
@stephane-airbyte stephane-airbyte requested review from a team, akashkulk, edgao, gisripa, postamar and rodireich and removed request for a team May 23, 2024 05:34
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from c870a2c to 06355c7 Compare May 23, 2024 14:21
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_calls_to_java_stream_ branch from 86bc96e to f759d9a Compare May 23, 2024 14:22
edgao
edgao approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubberstamping this :P I only reviewed the first 10ish files

...dk/core/src/main/kotlin/io/airbyte/cdk/integrations/destination/async/AsyncStreamConsumer.kt
)
},
),
streamNames.associateWith { streamDescriptor: StreamDescriptor ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh, TIL associateWith

(i'm immediately switching to associate here but it's still cool!)

@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented May 23, 2024 •
edited
Loading

Merge activity

@stephane-airbyte stephane-airbyte changed the base branch from stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct to graphite-base/37539 May 23, 2024 18:03
@stephane-airbyte stephane-airbyte changed the base branch from graphite-base/37539 to master May 23, 2024 18:10
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-24-remove_calls_to_java_stream_ branch from f759d9a to ded3aff Compare May 23, 2024 18:13
@stephane-airbyte stephane-airbyte merged commit 460cdca into master May 23, 2024
27 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/04-24-remove_calls_to_java_stream_ branch May 23, 2024 18:20
@stephane-airbyte stephane-airbyte mentioned this pull request May 23, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

@gisripa gisripa gisripa approved these changes

@akashkulk akashkulk Awaiting requested review from akashkulk

@postamar postamar Awaiting requested review from postamar

@rodireich rodireich Awaiting requested review from rodireich

Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephane-airbyte @gisripa @edgao @octavia-squidington-iii