-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Woocommerce: changes for builder compatibility #38334
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo in Readme Co-authored-by: Serhii Lazebnyi <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/woocommerce
labels
May 17, 2024
closing as duplicate of #42551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/woocommerce
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As part of the builder-compatible and silver certification. This PR creates a manifest, migrates to poetry and deletes old spec and schemas. New PR to avoid conflict with Brian's.
How
Migration to poetry, created a builder-generated manifest.yaml, deleted spec and schemas. Upgraded CDK to v0.88.
Review guide
manifest.yaml - created, integrated spec and generated with builder.
pyproject.toml - migrated to poetry and updated CDK dependency.
Deleted schemas and old spec.
metadata.yaml - added maxSecondsBetweenMessages
test_core.py - fixed CAT tests for clean CI.
User Impact
Able to use builder, general quality improvements.
Can this PR be safely reverted and rolled back?