Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(airbyte-ci)Skip breaking change validation for source declarative manifest #38535

Merged
merged 6 commits into from
May 21, 2024
Merged

fix(airbyte-ci)Skip breaking change validation for source declarative manifest #38535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad55587
Skip breaking change validation for source declarative manifest
girarda May 21, 2024
bc07a9e
extract to a constant
girarda May 21, 2024
de9ada4
Add test cases
girarda May 21, 2024
3ae7ea4
format
girarda May 21, 2024
63b6d16
rename test files
girarda May 21, 2024
df3a952
Merge branch 'master' into alex/bypass_validation
girarda May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions airbyte-ci/connectors/metadata_service/lib/metadata_service/validators/metadata_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ class ValidatorOptions:
ValidationResult = Tuple[bool, Optional[Union[ValidationError, str]]]
Validator = Callable[[ConnectorMetadataDefinitionV0, ValidatorOptions], ValidationResult]

_SOURCE_DECLARATIVE_MANIFEST_DEFINITION_ID = "64a2f99c-542f-4af8-9a6f-355f1217b436"


def validate_metadata_images_in_dockerhub(
metadata_definition: ConnectorMetadataDefinitionV0, validator_opts: ValidatorOptions
Expand Down Expand Up @@ -102,6 +104,13 @@ def validate_major_version_bump_has_breaking_change_entry(
if not is_major_version(image_tag):
return True, None

# We are updating the same version since connector builder projects have a different concept of
# versioning.
# We do not check for breaking changes for source-declarative-connector in the metadata because the conenctor isn't directly used by any workspace.
# Breaking changes are instead tracked at the CDK level
if str(metadata_definition.data.definitionId) == _SOURCE_DECLARATIVE_MANIFEST_DEFINITION_ID:
return True, None

docker_repo = get(metadata_definition_dict, "data.dockerRepository")
releases = get(metadata_definition_dict, "data.releases")
if not releases:
Expand Down
14 changes: 14 additions & 0 deletions ...lib/tests/fixtures/metadata_validate/invalid/metadata_major_bump_no_breaking_changes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
metadataSpecVersion: 1.0
data:
name: Low-code
definitionId: 1fa90628-2b9e-11ed-a261-0242ac120002
connectorType: source
dockerRepository: airbyte/image-exists-1
githubIssueLabel: source-alloydb-strict-encrypt
dockerImageTag: 1.0.0
documentationUrl: https://docs.airbyte.com/integrations/sources/existingsource
connectorSubtype: database
releaseStage: generally_available
license: MIT
tags:
- language:java
14 changes: 14 additions & 0 deletions .../metadata_validate/valid/metadata_declarative_manifest_major_bump_no_breaking_change.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
metadataSpecVersion: 1.0
data:
name: Low-code
definitionId: 64a2f99c-542f-4af8-9a6f-355f1217b436
connectorType: source
dockerRepository: airbyte/image-exists-1
githubIssueLabel: source-alloydb-strict-encrypt
dockerImageTag: 1.0.0
documentationUrl: https://docs.airbyte.com/integrations/sources/existingsource
connectorSubtype: database
releaseStage: generally_available
license: MIT
tags:
- language:java
Loading