airbyte-ci: introduce ConnectorTestContext #38628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/05-23-airbyte-ci_introduce_ConnectorContext
branch
from
27bfe26 to
54fcaaf
Compare
alafanechere
requested review from
a team,
bnchrch and
clnoll
and removed request for
a team
alafanechere
changed the title
bnchrch
approved these changes
May 23, 2024
alafanechere
deleted the
augustin/05-23-airbyte-ci_introduce_ConnectorContext
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#38615 made the
ConnectorContexttry to fetch secrets for tests on initialization.But the
ConnectorContextis the parent class ofPublishContext.It led to failures in the publish workflow because
PublishContextis not instantiated with the secret stores we use for testing.Instead of passing the test secret store to
PublishContextI find it more appropriate to create aConnectorTestContextsubclass in which the secret fetching for specific step is handled.