🐛 [source-airtable] next_page_token should adhere to HttpStream interface #38765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
bazarnov
approved these changes
May 29, 2024
|
Passing live test 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Airtable doesn't properly implement the
next_page_token()interfaces from theHttpStreamclass. Thanks to Python's lack of type checking we never noticed.How
Update the
next_page_token()implementations to emit a Mapping instead of a string. And on therequest_params()method used to populate the query params we should insert the entire map, not just the string.I also bumped the version to the latest CDK and removed the old legacy AirbyteLogger
Review guide
User Impact
None
Can this PR be safely reverted and rolled back?