Fix live test image when running in CI #38772
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
clnoll
changed the title
clnoll
force-pushed
the
catherine/fix-live-tests-image-in-ci
branch
2 times, most recently
from
41240a8 to
53b98ba
Compare
| if container_id_path.exists(): | ||
| return await get_container_from_id(dagger_client, container_id_path.read_text()) | ||
| if is_ci and is_target: | ||
| container_id_path = Path("/tmp/container_id.txt") |
There was a problem hiding this comment.
In order to not tie this utils to the regression test suite I'd suggest to make the airbyte-ci RegressionTests step write /tmp/<docker-image-name-with-tag>_container_id.txt and make this function check if such a file is available. It'd allow us to keep the original signature and avoid the problem we currently have.
There was a problem hiding this comment.
Let me know if it's too much, happy to 👍 to unblock.
There was a problem hiding this comment.
Thanks @alafanechere I made this change.
There was a problem hiding this comment.
@clnoll nice! Pre-approving! Can you double check it works? I wonder if it's risky to create file name with special characters like : (the image name with tag will contain a :).
|
@alafanechere the ":" indeed did not work so I'm just using the target image tag instead. Sound okay to you? |
I think you can use the |
clnoll
force-pushed
the
catherine/fix-live-tests-image-in-ci
branch
2 times, most recently
from
a8122fd to
f785f8e
Compare
Also fixes --selected-streams
clnoll
force-pushed
the
catherine/fix-live-tests-image-in-ci
branch
from
f785f8e to
3170d30
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
What
Fixes an issue where regression tests were using the same target & control containers when running in GHA.
This was flagged by @aldogonzalez8 when he realized that the target & control containers were hitting the same URLs, when they were expected to be different.
How
Avoid looking for a
connection_id.txtfile when in CI and getting the control container. When this file is present, we were building the control image off of it instead of pulling the latest image from Dockerhub, however it should only be used for the target image.Closes https://github.com/airbytehq/airbyte-internal-issues/issues/7950.