Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination Snowflake: Storage ops to support refreshes #39473

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Destination Snowflake: Storage ops to support refreshes #39473

merged 1 commit into from
Jul 1, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Jun 13, 2024

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Jun 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 11:20pm

This was referenced Jun 13, 2024
Merged
Merged
Merged
@gisripa Graphite App
Copy link
Contributor Author

gisripa commented Jun 13, 2024 •
edited by edgao
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

@gisripa gisripa mentioned this pull request Jun 13, 2024
Closed
2 tasks
@gisripa gisripa changed the title gireesh/snowflake_refreshes Destination Snowflake: Storage ops to support refreshes Jun 13, 2024
@gisripa gisripa force-pushed the edgao/core_interface_change branch from 2febcc9 to b73ecdd Compare June 13, 2024 19:34
@gisripa gisripa force-pushed the gireesh/06-13-gireesh_snowflake_refreshes branch from 72fbc25 to 1f52df4 Compare June 13, 2024 19:34
@gisripa gisripa force-pushed the edgao/core_interface_change branch from b73ecdd to 3db198d Compare June 13, 2024 19:37
@gisripa gisripa force-pushed the gireesh/06-13-gireesh_snowflake_refreshes branch 2 times, most recently from 0a991d4 to 013c59a Compare June 13, 2024 19:39
@edgao edgao force-pushed the edgao/core_interface_change branch 2 times, most recently from f821e82 to 66838d0 Compare June 13, 2024 22:31
@gisripa gisripa force-pushed the edgao/core_interface_change branch from 66838d0 to 3e6f038 Compare June 14, 2024 00:26
@gisripa gisripa force-pushed the gireesh/06-13-gireesh_snowflake_refreshes branch from 013c59a to 0c0b0ff Compare June 14, 2024 00:26
@edgao edgao force-pushed the edgao/core_interface_change branch 3 times, most recently from 9178356 to 19237b7 Compare June 14, 2024 16:00
@gisripa gisripa marked this pull request as ready for review June 14, 2024 16:34
@gisripa gisripa requested review from a team as code owners June 14, 2024 16:34
@stephane-airbyte stephane-airbyte force-pushed the edgao/core_interface_change branch from 19237b7 to c7720b1 Compare June 14, 2024 17:52
@stephane-airbyte stephane-airbyte force-pushed the gireesh/06-13-gireesh_snowflake_refreshes branch from 0c0b0ff to e2cf210 Compare June 14, 2024 17:52
@edgao edgao force-pushed the edgao/core_interface_change branch from c7720b1 to 19024dd Compare June 17, 2024 14:38
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 26, 2024
@stephane-airbyte stephane-airbyte force-pushed the gireesh/06-13-gireesh_snowflake_refreshes branch from 6bc0b19 to 8ec1316 Compare June 26, 2024 00:07
@stephane-airbyte stephane-airbyte requested a review from edgao June 26, 2024 00:41
@stephane-airbyte stephane-airbyte force-pushed the gireesh/06-13-gireesh_snowflake_refreshes branch from 8ec1316 to 5a25c83 Compare June 26, 2024 03:24
edgao
edgao approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 some nitpicks/clarifications, LGTM after resolving those :shipit:

airbyte-integrations/connectors/destination-snowflake/build.gradle Outdated Show resolved Hide resolved
...io/airbyte/integrations/destination/snowflake/typing_deduping/SnowflakeDestinationHandler.kt Show resolved Hide resolved
...es/kotlin/io/airbyte/integrations/base/destination/typing_deduping/BaseTypingDedupingTest.kt Outdated Show resolved Hide resolved
...es/kotlin/io/airbyte/integrations/base/destination/typing_deduping/BaseTypingDedupingTest.kt Outdated Show resolved Hide resolved
...ion/snowflake/typing_deduping/SnowflakeInternalStagingLowercaseDatabaseTypingDedupingTest.kt Outdated Show resolved Hide resolved
@stephane-airbyte stephane-airbyte force-pushed the gireesh/06-13-gireesh_snowflake_refreshes branch from 5a25c83 to d20a33d Compare June 26, 2024 16:53
@stephane-airbyte stephane-airbyte force-pushed the gireesh/06-13-gireesh_snowflake_refreshes branch from d20a33d to 1662eb2 Compare June 27, 2024 23:44
@stephane-airbyte stephane-airbyte force-pushed the gireesh/06-13-gireesh_snowflake_refreshes branch from 1662eb2 to 0a46c60 Compare July 1, 2024 22:43
@stephane-airbyte Graphite App
Copy link
Contributor

stephane-airbyte commented Jul 1, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/9752068439
✅ Successfully published Java CDK version=0.40.6!

@stephane-airbyte stephane-airbyte force-pushed the gireesh/06-13-gireesh_snowflake_refreshes branch from 0a46c60 to d781fd8 Compare July 1, 2024 22:49
@stephane-airbyte Graphite App
Copy link
Contributor

stephane-airbyte commented Jul 1, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/9752092029
✅ Successfully published Java CDK version=0.40.9!

@stephane-airbyte stephane-airbyte force-pushed the gireesh/06-13-gireesh_snowflake_refreshes branch from d781fd8 to 8e7ad5d Compare July 1, 2024 22:51
@stephane-airbyte stephane-airbyte force-pushed the gireesh/06-13-gireesh_snowflake_refreshes branch from 8e7ad5d to 6b5a8f7 Compare July 1, 2024 23:08
@stephane-airbyte stephane-airbyte force-pushed the gireesh/06-13-gireesh_snowflake_refreshes branch from 6b5a8f7 to c9a5981 Compare July 1, 2024 23:16
@stephane-airbyte stephane-airbyte merged commit 127c501 into master Jul 1, 2024
30 checks passed
@stephane-airbyte stephane-airbyte deleted the gireesh/06-13-gireesh_snowflake_refreshes branch July 1, 2024 23:54
This was referenced Jul 2, 2024
Closed
Closed
xiaohansong pushed a commit that referenced this pull request Jul 9, 2024
@gisripa @xiaohansong
Destination Snowflake: Storage ops to support refreshes (#39473)
0ac4d27
@ogirardot ogirardot mentioned this pull request Jul 22, 2024
Closed
1 task
@fauxpasonics fauxpasonics mentioned this pull request Jul 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephane-airbyte stephane-airbyte stephane-airbyte left review comments

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/snowflake connectors/source/clickup-api connectors/source/close-com connectors/source/tempo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gisripa @stephane-airbyte @edgao @octavia-squidington-iii