Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Younium : Migrate to Manifest-only #47281

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

topefolorunso
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 10:56am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/younium labels Oct 23, 2024
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 23, 2024 10:47
@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Oct 23, 2024

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (ca174e9)

Copy link
Contributor

@ChristoGrab ChristoGrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we have essentially no testing story for this connector. We don't have sandbox creds, and the only existing Cloud connection is using version 0.2.0, which predates the migration to the low-code framework.

Approving since I have no way of knowing if the current low-code version even works, and OSS users can pin to an earlier version if this change does break anything 🤷

@ChristoGrab ChristoGrab merged commit 3a6055d into master Oct 28, 2024
37 of 38 checks passed
@ChristoGrab ChristoGrab deleted the tope/younium/migrate-manifest-only branch October 28, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/younium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants