✨ Source Amazon Ads: Added targeting grouping into SponsoredBrandsV3ReportStream. #48756
+221
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mihaly-dombi is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
mihaly-dombi
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
mihaly-dombi
had a problem deploying
to
community-ci-auto
GitHub Actions
Failure
mihaly-dombi
had a problem deploying
to
community-ci
GitHub Actions
Error
mihaly-dombi
had a problem deploying
to
community-ci
GitHub Actions
Error
mihaly-dombi
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
mihaly-dombi
had a problem deploying
to
community-ci
GitHub Actions
Error
mihaly-dombi
had a problem deploying
to
community-ci
GitHub Actions
Error
mihaly-dombi
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
mihaly-dombi
force-pushed
the
mihaly/extend-metrics-for-sponsored-brands
branch
from
18dac8c to
3a77d31
Compare
mihaly-dombi
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
mihaly-dombi
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
mihaly-dombi
had a problem deploying
to
community-ci
GitHub Actions
Error
mihaly-dombi
had a problem deploying
to
community-ci
GitHub Actions
Error
mihaly-dombi
force-pushed
the
mihaly/extend-metrics-for-sponsored-brands
branch
from
3a77d31 to
4ca9ee5
Compare
mihaly-dombi
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
mihaly-dombi
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
mihaly-dombi
had a problem deploying
to
community-ci
GitHub Actions
Error
mihaly-dombi
had a problem deploying
to
community-ci
GitHub Actions
Error
marcosmarxm
requested changes
Dec 17, 2024
There was a problem hiding this comment.
@mihaly-dombi small addition so I can trigger tests and validate your change.
| @@ -13,7 +13,7 @@ data: | |||
| connectorSubtype: api | |||
| connectorType: source | |||
| definitionId: c6b0a29e-1da9-4512-9002-7bfd0cba2246 | |||
| dockerImageTag: 6.2.1 | |||
| dockerImageTag: 6.3.0 | |||
There was a problem hiding this comment.
You need also to add an entry in the docs changelog.
octavia-squidington-iii
added
the
area/documentation
mihaly-dombi
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
mihaly-dombi
had a problem deploying
to
community-ci
GitHub Actions
Error
mihaly-dombi
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
mihaly-dombi
had a problem deploying
to
community-ci
GitHub Actions
Error
mihaly-dombi
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
mihaly-dombi
had a problem deploying
to
community-ci
GitHub Actions
Failure
mihaly-dombi
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
mihaly-dombi
temporarily deployed
to
community-ci
GitHub Actions
Inactive
|
/format-fix
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Sponsored brands can be fetched through targeting report type grouping.
How
Extending
METRICS_MAP_V3withtargetinginSponsoredBrandsV3ReportStream.Extending
sponsored_brands_v3_report_stream.jsonwith the new metrics.Review guide
User Impact
They should get records with
targetingrecord type.Can this PR be safely reverted and rolled back?