Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return correct language tag when using Kotlin build script #49835

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Ensure language tag check passes for projects that use the Kotlin Gradle build script

How

  • Add conditional logic to check for build.gradle.kts file when looking for language tags

Review guide

  1. consts.py
  2. metadata.py

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@jdpgrailsdev jdpgrailsdev requested a review from a team as a code owner December 17, 2024 14:24
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 3:22pm

Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please bump the package version in pyproject.toml and add a changelog entry in the README file.

@jdpgrailsdev
Copy link
Contributor Author

LGTM! Please bump the package version in pyproject.toml and add a changelog entry in the README file.

@alafanechere D'oh -- totally forgot to do that. Will do and then will merge.

@jdpgrailsdev jdpgrailsdev merged commit 6d8a3a2 into master Dec 17, 2024
34 checks passed
@jdpgrailsdev jdpgrailsdev deleted the jonathan/kotlin-language-check branch December 17, 2024 15:46
@edgao
Copy link
Contributor

edgao commented Dec 17, 2024

@alafanechere now I'm curious - what does the metadata.yaml language tag do, if we have this language inference thing?

@alafanechere
Copy link
Contributor

@alafanechere now I'm curious - what does the metadata.yaml language tag do, if we have this language inference thing?

@edgao in this context we run a check to make sure the language tag is consistent with the inferred one. The check could be simplified and not be opinionated (just check the tag existence), but we introduced it to solve some inconsistency issue we had (python vs low-code vs manifest only etc.).

And to answer "what does it do": I think the language tag is solely used in our registry / for analytics. The CI control flow are mostly based on a language detection based on the similar kind of inferences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants