Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination Iceberg: Fix object type handling #49848

Draft
wants to merge 7 commits into
base: edgao/iceberg_glue_integration_test
Choose a base branch
from

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Dec 17, 2024

  • Add an expected record mapper, which transforms expected records into the same format that we write for iceberg (i.e. stringify {type: object, properties: {}} fields)
  • Use that record mapper in iceberg tests
  • update the data dumper to coerce values by their actual type, rather than by the declared schema
  • Update the RecordDiffer to correctly handle nullEqualsUnset in nested structs
  • TODO: timestamps are broken (class java.time.OffsetDateTime cannot be cast to class java.time.LocalDateTime)
  • TODO: connector still crashes on some {type: object} schemas

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 11:36pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues CDK Connector Development Kit connectors/destination/iceberg-v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants