-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(destination-firebolt): disable on-disk token caching #51560
base: master
Are you sure you want to change the base?
fix(destination-firebolt): disable on-disk token caching #51560
Conversation
@ptiurin is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
023e464
to
5434225
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to bump the connector version in metadata.yalm file inside the connector folder and add a connector changelog entry in connector docs.
Ok, done. |
What
Currently the latest(0.2.25) Firebolt destination version is failing to connect due to the disk access error from the OS.
This is due to the SDK caching a token for future use on the file system. New
airbyte
user introduced in the latest python base does not have permissions to access the required directory.How
Setting the flag to False disables an attempt to cache on filesystem, designed specifically for constrained environments.
User Impact
Firebolt destination will be usable again. Behind the scenes an additional http request will be run when establishing a connection, but this will barely impact timings overall.
Can this PR be safely reverted and rolled back?