Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(destination-firebolt): disable on-disk token caching #51560

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ptiurin
Copy link
Contributor

@ptiurin ptiurin commented Jan 15, 2025

What

Currently the latest(0.2.25) Firebolt destination version is failing to connect due to the disk access error from the OS.
image
This is due to the SDK caching a token for future use on the file system. New airbyte user introduced in the latest python base does not have permissions to access the required directory.

How

Setting the flag to False disables an attempt to cache on filesystem, designed specifically for constrained environments.

User Impact

Firebolt destination will be usable again. Behind the scenes an additional http request will be run when establishing a connection, but this will barely impact timings overall.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jan 15, 2025

@ptiurin is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to bump the connector version in metadata.yalm file inside the connector folder and add a connector changelog entry in connector docs.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 17, 2025
@ptiurin ptiurin temporarily deployed to community-ci-auto January 17, 2025 16:59 — with GitHub Actions Inactive
@ptiurin
Copy link
Contributor Author

ptiurin commented Jan 17, 2025

You need to bump the connector version in metadata.yalm file inside the connector folder and add a connector changelog entry in connector docs.

Ok, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/firebolt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants