airbyte-ci: correct mounted volumes ownership #51582
Merged
+28
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 16, 2025
alafanechere
force-pushed
the
augustin/01-16-airbyte-ci_mount_/tmp_with_the_current_user_as_owner
branch
from
a2a0c17 to
63313ab
Compare
alafanechere
force-pushed
the
augustin/01-16-airbyte-ci_mount_/tmp_with_the_current_user_as_owner
branch
from
63313ab to
846b12f
Compare
alafanechere
force-pushed
the
augustin/01-16-airbyte-ci_mount_/tmp_with_the_current_user_as_owner
branch
from
846b12f to
a0c9414
Compare
alafanechere
force-pushed
the
augustin/01-16-airbyte-ci_mount_/tmp_with_the_current_user_as_owner
branch
from
3580a7a to
86aca90
Compare
alafanechere
changed the title
alafanechere
force-pushed
the
augustin/01-16-airbyte-ci_mount_/tmp_with_the_current_user_as_owner
branch
2 times, most recently
from
a1a3906 to
dc96eaa
Compare
alafanechere
force-pushed
the
augustin/01-16-airbyte-ci_mount_/tmp_with_the_current_user_as_owner
branch
from
dc96eaa to
4660e5a
Compare
Comment on lines
+94
to
+95
| # Make sure the user has access to /tmp | ||
| customized_connector = customized_connector.with_exec(["chown", "-R", f"{user}:{user}", "/tmp"]) |
Comment on lines
857
to
858
| | 4.48.9 | [#51609](https://github.com/airbytehq/airbyte/pull/51609) | Fix typo in `migrate-to-inline-schemas` command | | ||
| | 4.48.8 | [#51582](https://github.com/airbytehq/airbyte/pull/51582) | Fix ownership of shared cache volume for non root connectors | |
There was a problem hiding this comment.
Aren't your changes 4.48.9? These logs seem to be in reverse order.
aldogonzalez8
approved these changes
Jan 17, 2025
alafanechere
force-pushed
the
augustin/01-16-airbyte-ci_mount_/tmp_with_the_current_user_as_owner
branch
from
4660e5a to
518aeed
Compare
alafanechere
deleted the
augustin/01-16-airbyte-ci_mount_/tmp_with_the_current_user_as_owner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of Docker environments and permissions in the Airbyte CI pipelines. The most important changes include making functions asynchronous, ensuring proper permissions for the
/tmpdirectory, and adding logging for storage driver selection.Improvements to Docker environment handling:
airbyte-ci/connectors/pipelines/pipelines/dagger/actions/system/docker.py: Modified multiple functions (with_bound_docker_host,with_docker_cli,load_image_to_docker_host) to be asynchronous to be able to fetch the current image user. [1] [2] [3] [4]airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/steps/gradle.py: Updated thegradle_containerto use the asynchronous version ofwith_bound_docker_host.airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/test/steps/python_connectors.py: Updated thetest_environmentto use the asynchronous version ofwith_bound_docker_host.Permissions and logging improvements:
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/build_image/steps/python_connectors.py: Ensured the user has access to the/tmpdirectory by changing its ownership.airbyte-ci/connectors/pipelines/pipelines/dagger/actions/system/docker.py: Added logging to indicate the storage driver being used based on the operating system.airbyte-ci/connectors/pipelines/pipelines/dagger/actions/system/docker.py: Ensured the/tmpdirectory and Docker volumes are properly owned by theairbyteuser and have appropriate permissions.