Update workflow to use compile-sketches action #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of straight CLI, uses the arduino/compile-sketches action. One immediate benefit is enabling deltas reports https://github.com/arduino/compile-sketches/tree/v1.1.2/?tab=readme-ov-file#enable-deltas-report This can show the change in flash and ram compared to the previous run https://github.com/MallocArray/arduino/actions/runs/12954136400/job/36135424360 ``` Compiling sketch: examples/OneOpenAir Compilation time elapsed: 6s Change in flash: 147290 (7.49%) Change in RAM for global variables: 2280 (0.7%) ``` A future improvement could be to also add https://github.com/arduino/report-size-deltas that can generate a comment on a PR that also shows the delta information.
|
Also removed the additional library installation, as current instructions at the top of the example sketches don't mention needing to install any additional libraries |
|
Feel free to choose another branch if desired. Develop wasn't the default branch, but looks like new code goes to it first, so I submitted it that way |
nick-4711
approved these changes
Feb 4, 2025
|
Since this is Approved, can it be completed so the merge finishes? |
samuelbles07
approved these changes
Feb 15, 2025
|
Addressed the comments |
|
Thank you for this @MallocArray ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of straight CLI, uses the arduino/compile-sketches action.
One immediate benefit is enabling deltas reports
https://github.com/arduino/compile-sketches/tree/v1.1.2/?tab=readme-ov-file#enable-deltas-report
This can show the change in flash and ram compared to the previous run https://github.com/MallocArray/arduino/actions/runs/12954136400/job/36135424360
A future improvement could be to also add https://github.com/arduino/report-size-deltas that can generate a comment on a PR that also shows the delta information.