-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FFM API instead of Unsafe #172
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/jdk-22-ffm
branch
from
May 11, 2024 17:20
e2cfdcd
to
93fc4f5
Compare
wendigo
force-pushed
the
serafin/jdk-22-ffm
branch
from
May 11, 2024 17:20
93fc4f5
to
a22bc02
Compare
wendigo
force-pushed
the
serafin/jdk-22-ffm
branch
from
May 11, 2024 21:55
a22bc02
to
7b3d159
Compare
They are already enforced by MemorySegment itself
cc @dain |
|
I got it working but I'm worried about performance. @dain can you take a look? |
dain
reviewed
May 15, 2024
dain
reviewed
Jun 30, 2024
dain
reviewed
Jun 30, 2024
dain
reviewed
Jun 30, 2024
martint
reviewed
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raw version - will add some cleanup/refactors