-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
2a60ec0
commit b8e7f70
Showing
3 changed files
with
6 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,3 +22,4 @@ run_tests$ | |
^install_ogrdbstats.R$ | ||
^make_sample_data.R$ | ||
^ogrdbstats.R$ | ||
^revdep$ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
Package: ogrdbstats | ||
Type: Package | ||
Title: Analysis of Adaptive Immune Receptor Repertoire Germ Line Statistics | ||
Version: 0.5.2 | ||
Version: 0.5.1 | ||
Authors@R: person( | ||
"William", "Lees", | ||
email = "[email protected]", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,8 @@ | ||
R CMD gives no errors or warnings, and one note stating that this is a | ||
new submission, which I cannot eliminate: | ||
## R CMD check results | ||
|
||
* checking CRAN incoming feasibility ... [8s] NOTE | ||
Maintainer: 'William Lees <[email protected]>' | ||
0 errors | 0 warnings | 0 notes | ||
|
||
New submission | ||
|
||
----------------- | ||
This is a minor update to resolve a problem notified by CRAN Package Check : https://cran.r-project.org/web/checks/check_results_ogrdbstats.html | ||
|
||
I confirm that I have read and agree to the CRAN Repository Policy. | ||
|
||
R CMD has beeen run on Windows, macOS and Linux using GitHub actions, and | ||
also using win_devel. | ||
|
||
----------------- | ||
|
||
Thank you for earlier feedback. Since then I have: | ||
- Proof-read the description text and made some changes | ||
- added a reference describing the methods to the description text | ||
- Replaced the use of T and F with TRUE and FALSE throughout the package | ||
- Added examples to all exported functions | ||
- Replaced print()/cat() with use message()/warning() | ||
- Removed all code that changed the user's current directory | ||
- reduced the execution time of example code | ||
- removed words that offended the spell checker | ||
|
||
Best wishes | ||
I reproduced and fixed the problem. Have tested on windows, ubuntu and macos - latest, ubuntu-latest devel. |