chore: make typedef EditSession.curOp consistent (#5698)

* move curOp typedef to init --------- Co-authored-by: Alice Koreman <[email protected]>
ajaxorg · Dec 17, 2024 · fcf6384 · fcf6384
1 parent 11e97dd
commit fcf6384
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/demo/test_package/index.ts b/demo/test_package/index.ts
@@ -124,11 +124,11 @@ function createPopup() {
 }
 
 const acePopup = createPopup();
-
 const activeCommand = acePopup.getData(acePopup.getRow());
 if (activeCommand && activeCommand.command && activeCommand.command.name) {
     acePopup.setData([]);
 }
+acePopup.destroy();
 
 const filter = new FilteredList([]);
 filter.setFilter("test");

diff --git a/src/edit_session.js b/src/edit_session.js
@@ -90,6 +90,7 @@ class EditSession {
     }
 
     $initOperationListeners() {
+        /**@type {import("../ace-internal").Ace.Operation | null}*/
         this.curOp = null;
         this.on("change", () => {
             if (!this.curOp) {
@@ -127,7 +128,6 @@ class EditSession {
         }
 
         this.$operationResetTimer.schedule();
-        /**@type {import("../ace-internal").Ace.Operation | null}*/
         this.curOp = {
             command: commandEvent.command || {},
             args: commandEvent.args

diff --git a/types/ace-modules.d.ts b/types/ace-modules.d.ts
@@ -890,7 +890,7 @@ declare module "ace-code/src/virtual_renderer" {
          * @param {EditSession} session The session to associate with
          **/
         setSession(session: EditSession): void;
-        session: import("ace-code").Ace.EditSession;
+        session: import("ace-code/src/edit_session").EditSession;
         /**
          * Triggers a partial update of the text, from the range given by the two parameters.
          * @param {Number} firstRow The first row to update