Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct highlight of PHP heredoc strings with one word on line #4847

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Jul 19, 2022

Issue #, if available: #3171

Description of changes:

  1. Fixing regexp in mini_require to support windows-style line breaks
  2. Fixing highlight of PHP heredoc strings with one word on line

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #4847 (ae4564c) into master (b9fabd4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4847      +/-   ##
==========================================
+ Coverage   70.05%   70.06%   +0.01%     
==========================================
  Files         557      557              
  Lines       58218    58220       +2     
  Branches    11195    11195              
==========================================
+ Hits        40783    40794      +11     
+ Misses      17435    17426       -9     
Flag Coverage Δ
unittests 70.06% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ace/mode/php_highlight_rules.js 93.33% <100.00%> (+19.19%) ⬆️
lib/ace/editor.js 82.47% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9fabd4...ae4564c. Read the comment docs.

@mkslanc mkslanc force-pushed the php-heredoc-highlight branch from 9b61fd3 to ae4564c Compare July 19, 2022 15:03
@mkslanc mkslanc marked this pull request as ready for review July 19, 2022 15:10
@andrewnester andrewnester self-requested a review July 19, 2022 16:10
@andrewnester andrewnester merged commit df70368 into ajaxorg:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants