Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Incorrect Module Reference for TypeScriptHighlightRules #5531

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

baguskah
Copy link
Contributor

@baguskah baguskah commented Apr 6, 2024

Issue #, if available: #5498

Description of changes:

It appear that this PR provides an incorrect module reference

var TypeScriptHighlightRules = require("./javascript_highlight_rules").TypeScriptHighlightRules;

This should actually reference ./typescript_highlight_rules. As a result, when attempting to access TypeScriptHighlightRules in tsx_highlight_rules, it returns undefined.

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (e59ae67) to head (b60efb5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5531      +/-   ##
==========================================
+ Coverage   86.61%   86.64%   +0.02%     
==========================================
  Files         591      593       +2     
  Lines       42732    42839     +107     
  Branches     7102     7120      +18     
==========================================
+ Hits        37012    37117     +105     
- Misses       5720     5722       +2     
Flag Coverage Δ
unittests 86.64% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightwing nightwing merged commit 7869158 into ajaxorg:master Apr 13, 2024
3 checks passed
@nightwing
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants