-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework search_images method completely to make it work again. Add utils ... #1
Open
abenassi
wants to merge
145
commits into
ajcasagrande:main
Choose a base branch
from
abenassi:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls module with methods used by the new search_images method. Remove BeatifulSoup module and replace it with requirements.txt with modules and versions needed to use Google-Search-API package after these changes.
Hi, I was looking for a repo to make image queries against Google and yours looked like the best designed to me, altough it seems you were not maintaining it for a long time. I have reworked search_images method so it almost fully works now (a few data fields couldn't be recovered from the new search engine -at least by me-) and I'd like to share the change with you. Thanks and regards! |
…at loads a test html file.
…epair convert curreny method.
…lasses to images module. Write tests for future currency module.
…thods in the main module with references to the methods written in the auxiliary modules.
…ges in the user interface.
…y private methods to implement later.
…ods are functional in its primary data target, some secondary data gathering is yet to be implemented. Redesign of the public API interface is completed.
Randomizing User-Agent
… Makefile with useful shortcuts. Build is broken and tests need to be fixed.
…nstead of Python 2. Many fixes are still required for it work.
update _get_link & add area param for search url
Add time parameter to search query
Added test_requirements.txt to MANIFEST.in.
To address issue #29
Update README.md
…hat use a '.' instead of ',' for thousand separator.
add support for sorting results by date
Fix error due to languages that use a dot instead of a comma as thousand separator.
Add first_page argument
… cassete because Google 403.
add a flag that returns if the URL is flagged as PDF by google
fix description scraper that breaks the search function and change package name to not conflict with other installed libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...module with methods used by the new search_images method. Remove BeatifulSoup module and replace it with requirements.txt with modules and versions needed to use Google-Search-API package after these changes.