Reveal getuv methods from pyspharm #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add doc strings to each class
versioneer was unhappy, use new build system to alleviate the pain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be desirable to perform vorticity / divergence surgery and then invert back to u/v components. pyspharm has this method internally and it'd be nice to reveal through the windspharm interfaces.
Seems to work well with pretty simple api calls, and some array checks on input. I duplicated the array checks used from
.gradient()in each interface but I think this could be refactored to also work for the inputs totruncate()andgradient()and reduce some duplicate code.I have no affinity to using the method name of
getuvfor now I just copied the pyspharm naming.This worked surprisingly well with the test suite so I'm trusting that it works and that the tests work, will use it on some real cases to confirm.
Example workflow for this utility:
https://colab.research.google.com/drive/1QcgI7IlQZnthnwCv42Y2pScuN1wWBCkn?usp=sharing