Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload delay debounce #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reload delay debounce #4

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
470945e
Reload delay debounce
romanzy313 Jun 4, 2023
d5bb54b
Added clearConsole option
romanzy313 Jun 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions lib/recharge.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'dart:async';
import 'dart:developer' as dev;
// import 'dart:js_interop'; //unused import
import 'package:vm_service/vm_service.dart' show VmService;
import 'package:vm_service/vm_service_io.dart' as vms;
import 'package:vm_service/utils.dart' as vmutils;
Expand All @@ -11,12 +12,15 @@ import 'package:watcher/watcher.dart';
class Recharge {
final String path;
final void Function()? onReload;
int delay;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make this Duration?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is up to you. I think keeping it the way it is now is okay too. Because delays are generally in millisecond range (500ms-20ms). 200ms seems like a good default value in my opinion

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not talking about the number. I meant to make the datatype Duration(milliseconds: 200) instead of int. It is better to use the built in datatype that is meant for this purpose.


String? _mainIsolate;
VmService? _service;
late DirectoryWatcher _watcher;
Timer? _timer;

Recharge({required this.path, this.onReload}) {
Recharge({required this.path, this.onReload, int delay = 200})
: delay = delay {
// This instance of watcher is going to be alive
// throughout the execution
_watcher = DirectoryWatcher(path);
Expand All @@ -27,8 +31,11 @@ class Recharge {
var name = event.type.toString().toUpperCase();
var path = event.path;
print("$name $path");
// Reload VM and fire onReload if it exists
if (await reload()) onReload?.call();
_timer?.cancel();
_timer = Timer(Duration(milliseconds: this.delay), () async {
await reload();
onReload?.call();
});
});
}

Expand All @@ -37,6 +44,9 @@ class Recharge {
init() async {
// Observatory URL is like: http://127.0.0.1:8181/u31D8b3VvmM=/
// Websocket endpoint for that will be: ws://127.0.0.1:8181/reBbXy32L6g=/ws

// print("application reloaded")

Comment on lines +57 to +59
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

final serverUri = (await dev.Service.getInfo()).serverUri;
if (serverUri == null) {
throw Exception("No VM service. Run with --enable-vm-service");
Expand Down