Skip to content

Commit

Permalink
RealVect Static: Export (AMReX-Codes#3589)
Browse files Browse the repository at this point in the history
## Summary

Export global symbols for Windows.

Seen in WarpX on conda-forge:
```
lld-link: warning: ignoring unknown argument '-lpthreads'
lld-link: error: undefined symbol: public: static class amrex::RealVect const amrex::RealVect::Zero
>>> referenced by libwarpx.rz.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.lib(SpectralKSpaceRZ.cpp.obj):(public: __cdecl SpectralKSpaceRZ::SpectralKSpaceRZ(class amrex::BoxArray const &, class amrex::DistributionMapping const &, class amrex::RealVect))
```

## Additional background

conda-forge/warpx-feedstock#72

## Checklist

The proposed changes:
- [x] fix a bug or incorrect behavior in AMReX
- [ ] add new capabilities to AMReX
- [ ] changes answers in the test suite to more than roundoff level
- [ ] are likely to significantly affect the results of downstream AMReX
users
- [ ] include documentation in the code and/or rst files, if appropriate
  • Loading branch information
ax3l authored Oct 9, 2023
1 parent 01b30b7 commit 77d4d1f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Src/Base/AMReX_RealVect.H
Original file line number Diff line number Diff line change
Expand Up @@ -521,13 +521,13 @@ public:
/**
This is a RealVect all of whose components are equal to zero.
*/
static const RealVect Zero;
static AMREX_EXPORT const RealVect Zero;

///
/**
This is a RealVect all of whose components are equal to one.
*/
static const RealVect Unit;
static AMREX_EXPORT const RealVect Unit;

/*@}*/

Expand Down

0 comments on commit 77d4d1f

Please sign in to comment.