Don't show toasts in CI

ajuvonen · Dec 13, 2024 · d46735c · d46735c
1 parent e1d9cec
commit d46735c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 22 deletions.
diff --git a/e2e/log.spec.ts b/e2e/log.spec.ts
@@ -17,12 +17,6 @@ test('logs veggies', async ({page}) => {
     'This Week 2 Veggies',
   );
 
-  const elements = await page.getByTestId('toast-message').all();
-  for (const element of elements) {
-    await element.click();
-  }
-
-  await expect(page.getByTestId('toast-message')).toBeHidden();
   await page.getByTestId('navbar-link-settings').click();
   await page.getByTestId('navbar-link-log').click();
   await expect(page.getByTestId('category-status-chart-center-label')).toHaveText(

diff --git a/e2e/stats.spec.ts b/e2e/stats.spec.ts
@@ -7,10 +7,6 @@ test("shows current week's veggies", async ({page}) => {
   await page.getByText(/^apple$/).click();
   await page.getByText('Apricot').click();
   await page.getByText('Avocado').click();
-  const elements = await page.getByTestId('toast-message').all();
-  for (const element of elements) {
-    await element.click();
-  }
   await page.getByTestId('navbar-link-stats').click();
   await expect(page.getByTestId('tag-apple')).toBeVisible();
   await expect(page.getByTestId('tag-apricot')).toBeVisible();

diff --git a/src/components/ToastContainer.vue b/src/components/ToastContainer.vue
@@ -8,13 +8,7 @@ const {messages} = storeToRefs(appStateStore);
 const {removeToastMessage} = appStateStore;
 </script>
 <template>
-  <TransitionGroup
-    tag="div"
-    name="toasts"
-    class="toast-container"
-    aria-live="polite"
-    @before-leave="() => console.log('before-leave')"
-  >
+  <TransitionGroup tag="div" name="toasts" class="toast-container" aria-live="polite">
     <ToastMessage
       v-for="message in messages"
       :key="message.id"

diff --git a/src/stores/appStateStore.ts b/src/stores/appStateStore.ts
@@ -41,10 +41,12 @@ export const useAppStateStore = defineStore('appState', () => {
   const messages = ref<Message[]>([]);
 
   const addToastMessage = (text: string) => {
-    messages.value.push({
-      id: crypto.randomUUID(),
-      text,
-    });
+    if (import.meta.env.MODE !== 'staging') {
+      messages.value.push({
+        id: crypto.randomUUID(),
+        text,
+      });
+    }
   };
 
   const removeToastMessage = (targetId: string) => {

diff --git a/src/views/LogView.vue b/src/views/LogView.vue
@@ -40,7 +40,7 @@ watch(currentVeggies, (newCurrentVeggies, oldCurrentVeggies) => {
       addToastMessage(t('toasts.challengeCompleted', [getCheer()]));
     } else if (allVeggies.value.length % 100 === 0) {
       addToastMessage(t('toasts.totalVeggies', [allVeggies.value.length, getCheer()]));
-    } else if (Math.random() <= 0.35) {
+    } else if (Math.random() <= 0.4) {
       const facts = [
         ...Object.values<string>(tm(`facts.${addedVeggie}`)),
         t('toasts.uniqueVeggies', [uniqueVeggies.value.length, ALL_VEGGIES.length, getCheer()]),