Added single-loop examples to 08a and 08b (EnKF) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the example 11, "Wofost72_PP_notebook_11.conf" is needed, but this file is not included in this project. Could you please add this file, or direct a path to download? Thanks for your project, and it is useful. |
|
Is this a notebook or a model configuration (.conf) file?
Allard
… Op 08-01-2024 04:33 CET schreef ZhiyiLiao ***@***.***>:
In the example 11, "Wofost72_PP_notebook_11.conf" is needed, but this file is not included in this project. Could you please add this file, or direct a path to download? Thanks for your project, and it is useful.
—
Reply to this email directly, view it on GitHub #19 (comment), or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJYCNT7KF2RQWF444XMUMDYNNSINAVCNFSM6AAAAAA76DEWVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGM2DAMZTHE.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
芷依已收到您发送的邮件，谢谢！
|
1 similar comment
|
芷依已收到您发送的邮件，谢谢！
|
|
Hi, I don't know if this was by design, but some of the functions for use in the loop (script 8a) are using the definitions of the previous steps (e.g. |
|
@mnqoliveira - are you referring to the version on the master branch or the version in this pull request? |
|
To the version in the pull request. I meant the final loop with the additional helper functions to run everything at once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added examples to both of the EnKF scripts, 08a and 08b, showing how to implement the EnKF assimilation in a single loop, which is how one would typically do it in practice. This may make it easier to translate the educational example to practical applications.
The branch to be pulled is already up-to-date with the current master branch. Only changes to the markdown, code, and new outputs are included; the notebook metadata are unchanged. All code has been tested.