Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix throwing error when calling stop and pause functions #274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix throwing error when calling stop and pause functions #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ios/TextToSpeech/TextToSpeech.m
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@powfix I would do the same on line 181 - it also throws the same error for me.

Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ + (BOOL)requiresMainQueueSetup
resolve([NSNumber numberWithUnsignedLong:utterance.hash]);
}

RCT_EXPORT_METHOD(stop:(BOOL *)onWordBoundary resolve:(RCTPromiseResolveBlock)resolve reject:(__unused RCTPromiseRejectBlock)reject)
RCT_EXPORT_METHOD(stop:(BOOL)onWordBoundary resolve:(RCTPromiseResolveBlock)resolve reject:(__unused RCTPromiseRejectBlock)reject)
{
AVSpeechBoundary boundary;

Expand All @@ -109,7 +109,7 @@ + (BOOL)requiresMainQueueSetup
resolve([NSNumber numberWithBool:stopped]);
}

RCT_EXPORT_METHOD(pause:(BOOL *)onWordBoundary resolve:(RCTPromiseResolveBlock)resolve reject:(__unused RCTPromiseRejectBlock)reject)
RCT_EXPORT_METHOD(pause:(BOOL)onWordBoundary resolve:(RCTPromiseResolveBlock)resolve reject:(__unused RCTPromiseRejectBlock)reject)
{
AVSpeechBoundary boundary;

Expand All @@ -132,7 +132,7 @@ + (BOOL)requiresMainQueueSetup
}


RCT_EXPORT_METHOD(setDucking:(BOOL *)ducking
RCT_EXPORT_METHOD(setDucking:(BOOL)ducking
resolve:(RCTPromiseResolveBlock)resolve
reject:(__unused RCTPromiseRejectBlock)reject)
{
Expand Down