Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(wallet): creates a unique wallet for each spec for each run #959

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ygrishajev
Copy link
Contributor

@ygrishajev ygrishajev commented Mar 7, 2025

This PR introduces a tests wallet setup for functional tests. This should solve 2 issues:

  1. account sequence mismatch issues when running same tests at the same time
  2. once we have a pg db generated for each run we'll be able to run tests in parallel and improve run time

Before each run:

  1. it generates a local faucet wallet
  2. fills it via sandbox faucet
  3. generates a unique wallet for every functional spec
  4. sends tokens from local faucet wallet to spec wallets
  5. sets spec wallet mnemonics in env

@ygrishajev ygrishajev requested a review from a team as a code owner March 7, 2025 16:01
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.72%. Comparing base (14ccc49) to head (0ec7bad).

Files with missing lines Patch % Lines
apps/api/src/billing/lib/wallet/wallet.ts 57.14% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (57.14%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #959       +/-   ##
===========================================
+ Coverage   11.84%   55.72%   +43.87%     
===========================================
  Files         448      226      -222     
  Lines       11916     5086     -6830     
  Branches     2525      721     -1804     
===========================================
+ Hits         1412     2834     +1422     
+ Misses       9937     2078     -7859     
+ Partials      567      174      -393     
Flag Coverage Δ
api 55.72% <57.14%> (?)
deploy-web ?
provider-proxy ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

stalniy
stalniy previously approved these changes Mar 7, 2025
baktun14
baktun14 previously approved these changes Mar 10, 2025
Copy link
Contributor

@baktun14 baktun14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@ygrishajev ygrishajev dismissed stale reviews from stalniy and baktun14 via ca23838 March 10, 2025 07:55
@ygrishajev ygrishajev requested review from stalniy and baktun14 March 10, 2025 07:55
stalniy
stalniy previously approved these changes Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants