Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce multi-line commands #968

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jzsfkzm
Copy link
Contributor

@jzsfkzm jzsfkzm commented Mar 8, 2025

refs #175

@jzsfkzm jzsfkzm requested a review from a team as a code owner March 8, 2025 15:09
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 9.73%. Comparing base (e8b2d5f) to head (e10fd4b).

Files with missing lines Patch % Lines
...deploy-web/src/components/sdl/CommandFormModal.tsx 0.00% 2 Missing ⚠️
apps/deploy-web/src/utils/sdl/sdlGenerator.ts 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main    #968      +/-   ##
=========================================
- Coverage   11.84%   9.73%   -2.12%     
=========================================
  Files         448     435      -13     
  Lines       11916   11504     -412     
  Branches     2533    2455      -78     
=========================================
- Hits         1412    1120     -292     
+ Misses       9939    9818     -121     
- Partials      565     566       +1     
Flag Coverage Δ
deploy-web 9.73% <80.95%> (+0.40%) ⬆️
provider-proxy ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


const lines = command.split("\n");

if (lines.length > 1 || command.startsWith("sh -c")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing the point here but there might be other executables out there then sh, should this be addressed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants