Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noble Network Support #833

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Conversation

PoolPirate
Copy link
Contributor

Adding support for the noble blockchain.
Don't know how to validate that NAMESPACE is correct, been using this for a while now and its been working just fine tho.

@tombeynon
Copy link
Collaborator

Thank you so much! Namespace is correct, it's just the binary name capitalised. I'll include in the next release

noble/README.md Outdated Show resolved Hide resolved
@tombeynon
Copy link
Collaborator

Pre-release image: ghcr.io/akash-network/cosmos-omnibus:v0.4.21-rc3-noble-v5.0.0

@tombeynon
Copy link
Collaborator

@PoolPirate any chance you can allow me to edit this PR so I can fix the conflicts? Sorry I should have merged this one first.

@PoolPirate
Copy link
Contributor Author

@tombeynon Don't have the option to enable that in the PR for some reason. Did resolve conflicts myself for this one, will see where I can enable that going forward

@PoolPirate
Copy link
Contributor Author

Ah well I see you mean to merge this for the next release.
Added you as a collab to the fork repo. Not the intended way but can't see that option to allow changes to the PR here.

@tombeynon
Copy link
Collaborator

I've come across that before, I don't think it's possible for organisation forks which is very annoying.. appreciate the invite though, that'll work great in the future.

I'll do another release with just this PR shortly, the release process has to be completed quickly once started as it breaks e.g. Akash Console. I wasn't sure you'd respond this quick 😅

@tombeynon
Copy link
Collaborator

Github broke so I had to cancel the action anyway

@tombeynon tombeynon merged commit eed19fc into akash-network:master Jul 17, 2024
72 checks passed
@tombeynon tombeynon deleted the add-noble branch July 17, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants