Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): fix tests on CI #1452

Merged
merged 8 commits into from
Nov 1, 2024
Merged

fix(ci): fix tests on CI #1452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
092a271
ci: set NX_DISABLE_DB
xnv Oct 31, 2024
2207c23
ci: set --verbose
xnv Oct 31, 2024
2c9b5ec
ci: set NX_DISABLE_DB true
xnv Oct 31, 2024
e40d716
build: recreate package-lock
xnv Oct 31, 2024
1d35313
test: fix tests
xnv Oct 31, 2024
c9d8d39
fix(serve): use @rollup/wasm-node to avoid platform-dependent trouble
xnv Oct 31, 2024
8629fe7
ci: recreate package-lock
xnv Nov 1, 2024
e32cb44
chore: remove --verbose from build
xnv Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,5 @@ jobs:
run: |
npm ci
npm test
env:
NX_DISABLE_DB: true
Copy link
Member Author

@xnv xnv Nov 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/akashic-games/akashic-cli/actions/runs/11395792247/job/31708603920#step:4:35 の回避。

NX (0 , native_1.connectToNxDb) is not a function

一時ディレクトリの書き込み権限の問題……という指摘もありますが、Github Actions での対処方法がよく分からず、安直に nrwl/nx#28205 のワークアラウンドを採用しています。

9,291 changes: 5,962 additions & 3,329 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions packages/akashic-cli-export/src/html/__tests__/apiUtilSpec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ describe("apiUtil", function () {
})
.catch(function (err: any) {
// レスポンスコードが不定のため先頭一致で判定
expect(err.message.startsWith(
"Failed to get resource. url: https://akashic-games.github.io/notfound. status code: ")
).toBe(true);
expect(err.message).match(
/^Failed to get resource\. url: https:\/\/akashic-games\.github\.io\/notfound\. status code:.*/
);
Copy link
Member Author

@xnv xnv Nov 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

別件。この件の作業中、サーバ側の問題か何かで一時的に失敗していた (？) のですが、 startsWith() だとテスト結果が true/false でしか分からないので、もう少し observable にしておきます。

});
});
});
Expand Down
Loading