Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Samuel Gomis <[email protected]>
  • Loading branch information
gwendalaubert and samokiss committed Jun 29, 2023
1 parent a8a2641 commit dd7987a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/Api/AssetManager/AssetAttributeOptionApi.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ public function upsert(string $assetFamilyCode, string $attributeCode, string $a
);
}

/**
* {@inheritdoc}
*/
public function upsertAsync(
string $assetFamilyCode,
string $attributeCode,
Expand Down
6 changes: 6 additions & 0 deletions src/Api/AttributeOptionApi.php
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,17 @@ public function upsertList($attributeCode, $attributeOptions): \Traversable
return $this->resourceClient->upsertStreamResourceList(static::ATTRIBUTE_OPTIONS_URI, [$attributeCode], $attributeOptions);
}

/**
* {@inheritdoc}
*/
public function upsertAsyncList($attributeCode, $attributeOptions): PromiseInterface|Promise
{
return $this->resourceClient->upsertAsyncStreamResourceList(static::ATTRIBUTE_OPTIONS_URI, [$attributeCode], $attributeOptions);
}

/**
* {@inheritdoc}
*/
public function upsertAsync($attributeCode, $attributeOptionCode, array $data = []): PromiseInterface|Promise
{
return $this->resourceClient->upsertAsyncResource(static::ATTRIBUTE_OPTION_URI, [$attributeCode, $attributeOptionCode], $data);
Expand Down

0 comments on commit dd7987a

Please sign in to comment.