fix: remove unnecessary assignment of variables after undefined check…

… in haltian thingsee enviornment device

fix: milesight WS136 non-standard hex utils invocation
fix: hex utils to behave the same way as in script-runner
fix: add dotenv dependency (still doesn't work on jetbrains IDEs though)

lib/hex/hex.js

@@ -1,5 +1,5 @@
 // Creating little endian hex DCBA
-exports.hexLittleEndianToBigEndian = (hex, signed) => {
+exports.hexLittleEndianToBigEndian = (hex, signed = true) => {
   const hexArray = [];
   let tempHex = hex;
   while (tempHex.length >= 2) {

lib/test/utils.js

@@ -2,6 +2,7 @@ const fs = require("fs");
 const chai = require("chai");
 const request = require("sync-request");
 const { validate } = require("jsonschema");
+require('dotenv').config()
 
 const { assert } = chai;
 const bits = require("bits");

package.json

@@ -26,5 +26,8 @@
     "rewire": "^5.0.0",
     "sync-request": "^6.1.0",
     "test-utils": "file:lib/test"
+  },
+  "dependencies": {
+    "dotenv": "^16.3.1"
   }
 }

types/haltian/thingseeEnvironment/uplink.js

@@ -80,11 +80,6 @@ function consume(event) {
         sample.neighRadioPowerDbm = neighRadioPowerDbm;
       }
 
-      sample.rssiDbm = rssiDbm;
-      sample.neighNodeInfo = neighNodeInfo;
-      sample.neighRadioPower = neighRadioPower;
-      sample.neighRadioPowerDbm = neighRadioPowerDbm;
-
       break;
     }
     case 1312: {
@@ -125,11 +120,6 @@ function consume(event) {
         sample.light = light;
       }
 
-      sample.pressure = pressure;
-      sample.humidity = humidity;
-      sample.temperature = temperature;
-      sample.light = light;
-
       break;
     }
     case 12101: {

types/milesight/WS136/uplink.js

@@ -55,7 +55,7 @@ function consume(event) {
     // PRESS STATE
     else if (channelId === 0xff && channelType === 0x34) {
       data.buttonNumber = bytes[i];
-      data.command = Hex.hexLittleEndianToBigEndian(payload.substr(++i * 2, 4));
+      data.command = Hex.hexLittleEndianToBigEndian(payload.substr(++i * 2, 4), false);
       i += 1;
     } else {
       break;