-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pypi packaging + more #54
base: phase0
Are you sure you want to change the base?
Conversation
man!! that's marvelous Let me spin a test environment to test all these stuff |
I will close #51 since it is included in this one too. I wanted to separate my work to smaller PRs but in the end it is one huge:) Sorry.. |
I did a couple of tests, things seems fine but I need to run some more tests, I think I might put this in a separate branch till I pypi upload is done and I modify my install playbook. Ah, and I need to add some bugfixes and enhancements unrelated to your changes as well. Many thanks for the contribution, if you have other ideas to add please let me know. |
Hi, how is testing going? Do you have any idea when this is gonna be merged? |
Hey there, apologies for the delays, I got hooked up in some stuff in my day job, will wrap it up and will get back to this, hopefully this weekend. |
Hi,
I guess I just let myself be carried away a little bit with this packaging thing:)
I changed a lot of things. Mainly in file structure, I split some files to more smaler ones. But now we have true Python package. \o/
Here are some things I've done:
aker
andakerctl
commands available in your system. It is same as runningpython -m aker.cli.aker
orpython -m aker.cli.akerctl
from project diraker.py
toaker/aker.py
andaker/cli/aker.py
.akerctl.py
I did something similar, spitting it toaker/commands.py
andaker/cli/akerctl.py
pyte
directory and added it as proper dependency torequirements.txt
..format()
in logging messages - use proper way of%s
and passing variables as argumentsargparse
related things, added few arguments toakerctl
I tried to record and replay the session using
aker.idp.json.Json
provider - all was ok.Please let me know if anything seems weird to you so we can change it before merging:)