feat: support the flattening syntax for supervising #32465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roiocam
force-pushed
the
flatten-supervising
branch
from
7654d09 to
dfaccbc
Compare
patriknw
reviewed
Aug 28, 2024
akka-actor-typed/src/main/scala/akka/actor/typed/javadsl/Behaviors.scala
Outdated
Show resolved
Hide resolved
|
Retriggering CI after #32489 |
Roiocam
force-pushed
the
flatten-supervising
branch
from
1597d12 to
92021e9
Compare
johanandren
reviewed
Sep 26, 2024
| Behaviors | ||
| .supervise(behavior) | ||
| .whenFailure[IllegalStateException](SupervisorStrategy.restart) | ||
| .whenFailure[IllegalArgumentException](SupervisorStrategy.stop) |
There was a problem hiding this comment.
We should show this as the main way now that we have it, not sure we need to show the other one at all
| whenFailure(strategy)(ClassTag(clazz)) | ||
|
|
||
| private[akka] def unwrap: Behavior[T] = wrapped | ||
| } |
There was a problem hiding this comment.
Unfortunate that the entire class needs to be public, but maybe separating in public trait and impl would be tricky. Make it final and replace "not for user extension" with "Not for user instantiation.
@InternalApi would mean the entire type is internal but we return it so drop that but put it on the unwrap method which becomes public from Java.
| */ | ||
| def onFailure[Thr <: Throwable](clazz: Class[Thr], strategy: SupervisorStrategy): Behavior[T] = | ||
| Supervisor(Behavior.validateAsInitial(wrapped), strategy)(ClassTag(clazz)) | ||
| new SuperviseBehavior[T](wrapped).whenFailure(clazz, strategy).unwrap |
There was a problem hiding this comment.
Would it not be safe to change the return type here to a subtype of Behavior and not need the separate whenFailure name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #31350