-
Couldn't load subscription status.
- Fork 3.6k
Update circuitbreaker.md #32556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azarboon
wants to merge
1
commit into
akka:main
Choose a base branch
from
azarboon:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update circuitbreaker.md #32556
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you contribution @azarboon.
However, I don't think the added paragraph is helping understand Akka's circuit breakers.
The example that of a system being brought down doesn't seem to apply. If you have a distributed database, the access to the instances is managed by some connection pool + driver. The application itself won't be connecting to db shards individually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. How about cell based architecture? May I change the example to that?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. What is missing in the Akka documentation about Circuit Breakers that needs to be addressed?
It's good if we have a succinct, high-level, explanation about the concept of Circuit Breakers followed by how to use the Akka APIs.
But if the intro about Circuit Breakers is too extensive, then we miss the main goal. The are enough resources on the internet (articles, blogs, videos) about it and interested users will dig the web for more information.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. But the problem is that the problem I mentioned, is not well known. Marc Brooker has written an excellent post explaining this. But it's buried and not well-known. So, I'm attempting to evangelize it so builders can be informed. Given that Akka is a well-known resource, it would be great if it evangelizes about challenges of this pattern. I'm thinking maybe we can add a link to that post for further reading? This way we can keep the doc succinct while giving heads-up to builders. What's your advice?