Abort on the commit log not being able to consume #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now abort if there are problems read from the commit log. All bets are off. If a problem occurs due to the data format having changed then it is on the programmer to upgrade the deserialisation.
patriknw
reviewed
Nov 14, 2023
| @@ -398,7 +397,7 @@ where | |||
| ); | |||
| } | |||
| Err(e) => { | |||
| warn!("When consuming: {e:?}"); | |||
| panic!("When consuming: {e:?}. Having to abort as this is unrecoverable."); | |||
There was a problem hiding this comment.
I think the error message should hint about what the user can do about it, such as implementing a serializer that can read or convert the old format.
There was a problem hiding this comment.
I agree, and did think about that. However, the error may be due to a host of issues which are described by the string in the error (which will get printed here). For example, the secret store may not be available, or there’s a missing header value…
In summary, I’m not in a position to determine the actual cause. But I think we are ok given the description string of the error.
There was a problem hiding this comment.
right, I think I didn't see that the cause is included
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now abort if there are problems read from the commit log. All bets are off. If a problem occurs due to the data format having changed then it is on the programmer to upgrade the deserialisation.
Fixes #122