Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Per request instance factory for Java DSL #2015

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

johanandren
Copy link
Member

@johanandren johanandren commented Jan 20, 2025

Functionality for integrating Akka gRPC generated Java services as endpoints in Akka SDK.

@johanandren johanandren marked this pull request as ready for review January 21, 2025 14:07
Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a question...

Did you call it ScalaHandler because it's based on a Scala PF?

It's a little weird that a parameter called generate_scala_handler_factory generates a Java file.

@johanandren
Copy link
Member Author

It's ScalaHandler because the public API of it is Scala (PF and Future) for folding into a Scala HTTP server, compared to the normal handler factory which has API to create akka.japi.function.Function and CompletionStage to be bound using the Java API of Akka HTTP

@johanandren
Copy link
Member Author

And, should I perhaps add, generated as Java to not require Akka SDK projects to have a Scala compilation step.

@johanandren johanandren merged commit bf2f035 into main Jan 21, 2025
12 checks passed
@johanandren johanandren deleted the wip-per-request-service branch January 21, 2025 16:25
@johanandren johanandren added this to the 2.5.1 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants