Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: replace jabba by proper debian installation #3539

Merged
merged 1 commit into from
Apr 19, 2021
Merged

build: replace jabba by proper debian installation #3539

merged 1 commit into from
Apr 19, 2021

Conversation

jrudolph
Copy link
Member

No description provided.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Oct 15, 2020
@akka-ci
Copy link

akka-ci commented Oct 15, 2020

Test PASSed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins and removed tested PR that was successfully built and tested by Jenkins labels Oct 15, 2020
@akka-ci akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins and removed validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Oct 15, 2020
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Oct 15, 2020
@akka-ci
Copy link

akka-ci commented Oct 15, 2020

Test PASSed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins and removed tested PR that was successfully built and tested by Jenkins labels Oct 15, 2020
@jrudolph jrudolph force-pushed the remove-jabba branch 2 times, most recently from 577476e to f61063e Compare October 15, 2020 13:55
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Oct 15, 2020
@akka-ci
Copy link

akka-ci commented Oct 15, 2020

Test PASSed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins and removed tested PR that was successfully built and tested by Jenkins labels Oct 15, 2020
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Oct 15, 2020
@akka-ci
Copy link

akka-ci commented Oct 15, 2020

Test PASSed.

@akka-ci akka-ci added the validating PR that is currently being validated by Jenkins label Oct 15, 2020
@jrudolph
Copy link
Member Author

What's the precedence for using sdkman as an official way of installing packages? I'd vote for using an official repository instead of introducing unnecessary third-parties. I'd rather go back to manual downloading of an JDK instead of using another tool.

@ignasi35
Copy link
Member

What's the precedence for using sdkman as ...

Mostly consistence with other projects in the org.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins and removed tested PR that was successfully built and tested by Jenkins labels Apr 19, 2021
@akka-ci akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins and removed validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Apr 19, 2021
@akka-ci akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins and removed validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Apr 19, 2021
@akka-ci akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins and removed validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Apr 19, 2021
@jrudolph
Copy link
Member Author

Let's try to merge this and see if it works.

@jrudolph jrudolph merged commit 6a5b1fb into akka:master Apr 19, 2021
@jrudolph jrudolph deleted the remove-jabba branch April 19, 2021 13:12
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Apr 19, 2021
@akka-ci
Copy link

akka-ci commented Apr 19, 2021

Test PASSed.

@jrudolph jrudolph restored the remove-jabba branch April 19, 2021 13:24
jrudolph added a commit to jrudolph/akka-http that referenced this pull request Apr 19, 2021
@jrudolph
build: replace jabba by proper debian installation (akka#3539)
5dc5ab1 
(cherry picked from commit 6a5b1fb)
jrudolph added a commit that referenced this pull request Apr 19, 2021
@jrudolph
Merge pull request #3801 from jrudolph/publish-to-sonatype-directly-1…
971cf72 
…0.1 (#3801)

* build: publish to sonatype directly (#3792)


(cherry picked from commit b7f057d)

* build: replace jabba by proper debian installation (#3539)


(cherry picked from commit 6a5b1fb)

* build: make sure launcher is downloaded from correct repo

(cherry picked from commit abb6aa4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrudolph @akka-ci @ignasi35 @raboof