Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate build system to net8 / fake v6 #361

Merged
merged 7 commits into from
Apr 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .config/dotnet-tools.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@
"commands": [
"jb"
]
},
"docfx": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WE can probably get rid of DocFx altogether (it was just part of the template for this repo) but I appreciate you doing this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will probably make CI faster. I figured it could be executed from some over place where the documentation is built, so I tried to keep it comparability reasons

"version": "2.76.0",
"commands": [
"docfx"
]
}
}
}
5 changes: 2 additions & 3 deletions Akka.Persistence.Sql.sln
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,12 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "_", "_", "{20C26B2D-59EA-42
README.md = README.md
RELEASE_NOTES.md = RELEASE_NOTES.md
serve-docs.cmd = serve-docs.cmd
serve-docs.ps1 = serve-docs.ps1
serve-docs.sh = serve-docs.sh
src\Directory.Build.props = src\Directory.Build.props
src\Directory.Packages.props = src\Directory.Packages.props
build.cmd = build.cmd
build.fsx = build.fsx
build.ps1 = build.ps1
build.sh = build.sh
build.fsx = build.fsx
EndProjectSection
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "build-system", "build-system", "{7537908B-6A42-4E34-889F-6004A97D4987}"
Expand Down
3 changes: 3 additions & 0 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
#### 1.5.14-alpha April 19 2024 ###
* [Migrate build system to FAKE v6 and dotnet 8](https://github.com/akkadotnet/Akka.Persistence.Sql/pull/361)

#### 1.5.13 September 28 2023 ###

* [Update Akka.NET to 1.5.13](https://github.com/akkadotnet/akka.net/releases/tag/1.5.13)
Expand Down
4 changes: 2 additions & 2 deletions build-system/azure-pipeline.template.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ jobs:
persistCredentials: true

- task: UseDotNet@2
displayName: 'Use .NET 7'
displayName: 'Use .NET 8'
inputs:
version: '7.x'
version: '8.x'

# Linux or macOS
- task: Bash@3
Expand Down
4 changes: 2 additions & 2 deletions build-system/windows-release.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ variables:

steps:
- task: UseDotNet@2
displayName: 'Use .NET 7'
displayName: 'Use .NET 8'
inputs:
version: '7.x'
version: '8.x'

- task: BatchScript@1
displayName: 'FAKE Build'
Expand Down
2 changes: 1 addition & 1 deletion build.cmd
Original file line number Diff line number Diff line change
@@ -1 +1 @@
PowerShell.exe -file "build.ps1" %*
dotnet fsi build.fsx -- -t %*
Loading