Update to handle catalog IT validation(resolve schema from subject) #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
May 27, 2024
Comment on lines
278
to
289
| if (assertion.resolve) | ||
| { | ||
| String schema = handler.resolve(id); | ||
| if (assertion.schema == null && schema != null) | ||
| { | ||
| doInitialReset(traceId); | ||
| } | ||
| else if (assertion.schema != null && !assertion.schema.equals(schema)) | ||
| { | ||
| doInitialReset(traceId); | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we need to add the explicit concept of resolve as a boolean, or is it sufficient to derive that intent from assertion.schema != null instead ?
This perhaps seems more intuitive since it would read as asserting the id and schema, agree?
jfallows
requested changes
May 28, 2024
| @@ -275,7 +278,7 @@ private void onInitialBegin( | |||
| { | |||
| doInitialReset(traceId); | |||
| } | |||
| if (assertion.resolve) | |||
| if (!Objects.equals(DEFAULT_ASSERTION_SCHEMA, assertion.schema)) | |||
There was a problem hiding this comment.
Suggested change
| if (!Objects.equals(DEFAULT_ASSERTION_SCHEMA, assertion.schema)) | |
| if (assertion.schema != DEFAULT_ASSERTION_SCHEMA) |
| @@ -275,7 +278,7 @@ private void onInitialBegin( | |||
| { | |||
| doInitialReset(traceId); | |||
| } | |||
| if (assertion.resolve) | |||
| if (!Objects.equals(DEFAULT_ASSERTION_SCHEMA, assertion.schema)) | |||
| { | |||
| String schema = handler.resolve(id); | |||
| if (assertion.schema == null && schema != null) | |||
There was a problem hiding this comment.
if (!Objects.equals(assertion.schema, schema))
{
doInitialReset(traceId);
}
jfallows
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.