Ztable support and convert transformation logic to state machine #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrambek
commented
Dec 18, 2024
| } | ||
|
|
||
| return state; | ||
| return onReadyHandler.onReady(traceId, authorization); |
There was a problem hiding this comment.
onReadyHandler.ready( I think it will be better
jfallows
requested changes
Dec 18, 2024
Comment on lines
145
to
148
| handler.doFlushProxy(traceId, authorization, flushEx); | ||
| onReadyHandler = terminateState; | ||
|
|
||
| return this; |
There was a problem hiding this comment.
Shouldn't this return an error state instead, which calls handler.doReady(...) for onReady(...)?
Then I think we don't need to introduce a separate ready handler interface as the transition is captured by moving to a different state.
jfallows
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.