Enable Ubuntu 20.04 compatibility

akloeker · Feb 9, 2024 · e09f12c · e09f12c
1 parent 12eeb91
commit e09f12c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/data-driven-development/data_generation.py b/data-driven-development/data_generation.py
@@ -57,7 +57,9 @@ def start_permutation_simulations(docker, permutation_configs, setting_configs):
                 # update environment variables to pass to docker-compose-file
                 print("Starting data generation with Config: {}".format(simulation_args))
                 os.environ.update(simulation_args)
-                docker.compose.up(abort_on_container_exit=True, services=setting_configs["simulation_services"], pull='always')
+                # explicitely pull the images before to enable Ubuntu 20.04 compatibility
+                docker.compose.pull()
+                docker.compose.up(abort_on_container_exit=True, services=setting_configs["simulation_services"])
                 docker.compose.down()
 
                 print("Config finished!")
@@ -109,7 +111,9 @@ def start_scenario_runner_simulations(docker, scenario_configs, setting_configs)
 
                         print("Starting data generation with scenario: {}".format(filename))
                         os.environ.update(scenario_args)
-                        docker.compose.up(abort_on_container_exit=True, services=setting_configs["simulation_services"], pull='always')
+                        # explicitely pull the images before to enable Ubuntu 20.04 compatibility
+                        docker.compose.pull()
+                        docker.compose.up(abort_on_container_exit=True, services=setting_configs["simulation_services"])
                         docker.compose.down() 
                         print("Finished scenario: {} with sensors_config: {}".format(filename, sensors_config_filepath))
 

diff --git a/utils/requirements.md b/utils/requirements.md
@@ -2,7 +2,7 @@
 
 > [!IMPORTANT]  
 > The core requirements for using our simulation framework CARLOS are listed below:
-> - [Ubuntu 22.04 LTS Jammy](https://ubuntu.com/download/desktop) (or higher) with `sudo` permission
+> - [Ubuntu 20.04 LTS Focal](https://ubuntu.com/download/desktop) (or higher) with `sudo` permission
 > - enough hard disk storage, which depends on the workshop and use-case (~50 GB are recommended)
 > - NVIDIA GPU (at least 8 GB GPU memory are recommended)