Skip to content

Commit

Permalink
온보딩에서 일어나는 앱 크래시 버그를 핫픽스합니다. (telling-me#149)
Browse files Browse the repository at this point in the history
  • Loading branch information
akrudal authored Oct 7, 2023
2 parents 8c89f12 + 40a1257 commit e0b1a9e
Show file tree
Hide file tree
Showing 7 changed files with 61 additions and 11 deletions.
8 changes: 6 additions & 2 deletions TellingMe/tellingMe.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@
585A93942AB6AA9900C9B705 /* ShareDTO.swift in Sources */ = {isa = PBXBuildFile; fileRef = 585A93932AB6AA9900C9B705 /* ShareDTO.swift */; };
585A93962AB6AAA300C9B705 /* ShareAPI.swift in Sources */ = {isa = PBXBuildFile; fileRef = 585A93952AB6AAA300C9B705 /* ShareAPI.swift */; };
586061D72AC16A1400FE2733 /* TimeManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = 586061D62AC16A1400FE2733 /* TimeManager.swift */; };
586805DB2AD03CFC009EEA61 /* AnalyzeManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = 586805DA2AD03CFC009EEA61 /* AnalyzeManager.swift */; };
58690DA62AB2FBF4002BAB82 /* UIImage+.swift in Sources */ = {isa = PBXBuildFile; fileRef = 58690DA52AB2FBF4002BAB82 /* UIImage+.swift */; };
586EC5AB2AA85CAB003981A6 /* MyPageToggleTableViewCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 586EC5AA2AA85CAB003981A6 /* MyPageToggleTableViewCell.swift */; };
5876D10B2AA17CD0009BF9DA /* StringLiteral.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5876D10A2AA17CD0009BF9DA /* StringLiteral.swift */; };
Expand Down Expand Up @@ -586,6 +587,7 @@
585A93932AB6AA9900C9B705 /* ShareDTO.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ShareDTO.swift; sourceTree = "<group>"; };
585A93952AB6AAA300C9B705 /* ShareAPI.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ShareAPI.swift; sourceTree = "<group>"; };
586061D62AC16A1400FE2733 /* TimeManager.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TimeManager.swift; sourceTree = "<group>"; };
586805DA2AD03CFC009EEA61 /* AnalyzeManager.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AnalyzeManager.swift; sourceTree = "<group>"; };
58690DA52AB2FBF4002BAB82 /* UIImage+.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UIImage+.swift"; sourceTree = "<group>"; };
586EC5AA2AA85CAB003981A6 /* MyPageToggleTableViewCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MyPageToggleTableViewCell.swift; sourceTree = "<group>"; };
5876D10A2AA17CD0009BF9DA /* StringLiteral.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StringLiteral.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -1879,6 +1881,7 @@
58BFBB402AADA1CC004A84E8 /* VersionManager.swift */,
58B735182AA4A8C5007485F7 /* MetaManager.swift */,
586061D62AC16A1400FE2733 /* TimeManager.swift */,
586805DA2AD03CFC009EEA61 /* AnalyzeManager.swift */,
);
path = managers;
sourceTree = "<group>";
Expand Down Expand Up @@ -2407,6 +2410,7 @@
583D305C2ABED3B900E99FBA /* HomeModel.swift in Sources */,
3AB213202A8922DD0035EA56 /* ToastMessage.swift in Sources */,
58690DA62AB2FBF4002BAB82 /* UIImage+.swift in Sources */,
586805DB2AD03CFC009EEA61 /* AnalyzeManager.swift in Sources */,
3A89B3C62A78C312002DFBCD /* SortHeaderView.swift in Sources */,
3AB795782A6E960F009961CF /* CommunityViewController.swift in Sources */,
3AA1677729E830BA00B93850 /* PageRepository.swift in Sources */,
Expand Down Expand Up @@ -2718,7 +2722,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.3.32;
MARKETING_VERSION = 1.4.1;
PRODUCT_BUNDLE_IDENTIFIER = com.tellingUs.tellingMe;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_EMIT_LOC_STRINGS = YES;
Expand Down Expand Up @@ -2751,7 +2755,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.3.32;
MARKETING_VERSION = 1.4.1;
PRODUCT_BUNDLE_IDENTIFIER = com.tellingUs.tellingMe;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_EMIT_LOC_STRINGS = YES;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import UIKit

import FirebaseAnalytics
import RxCocoa
import RxSwift

Expand Down Expand Up @@ -35,6 +36,7 @@ final class HHomeViewController: BBaseViewController {
super.viewDidLoad()
passDeviceDimension()
setNotificationCenterForBecomeActive()
analyze()
}

override func viewWillAppear(_ animated: Bool) {
Expand Down Expand Up @@ -348,6 +350,13 @@ extension HHomeViewController {
animateBackground()
}
}

extension HHomeViewController {
private func analyze() {
GAManager.shared.logEvent(eventType: .screen(screenName: "Home 화면"))
}
}

// MARK: - Delegates
extension HHomeViewController: DismissAndSwitchTabDelegate {
func dismissAndSwitchTab(to index: Int) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ extension HomeHoverView {
let coloredText: String = "진정한 나"
titleLabel.attributedText = setPartialTextGreen(text: text, targetText: coloredText, attributes: colorAttributes)
} else {
let text: String = "연속 \(day)일째 답변 중!"
let text: String = "연속 \(day)일째 기록 중!"
titleLabel.attributedText = setNumberTextGreen(text: text, attributes: colorAttributes)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ final class HomeQuestionView: BBaseView {
$0.backgroundColor = .clear
$0.textAlignment = .center
$0.textColor = .Logo
$0.text = "답변 완료!"
$0.text = "기록 완료!"
$0.font = .fontNanum(.C1_Bold)
$0.isHidden = true
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,10 @@ final class OnBoardingViewController: UIViewController {
}

private func pushSignUp() {
let storyboard = UIStoryboard(name: "SignUp", bundle: nil)
guard let vc = storyboard.instantiateViewController(withIdentifier: "signUp") as? SignUpViewController else {
return
}
vc.modalPresentationStyle = .fullScreen
self.present(vc, animated: true)
let signUpViewController = SignUpViewController()
signUpViewController.modalPresentationStyle = .fullScreen

self.present(signUpViewController, animated: true)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ extension MyPageProfileView {
let coloredText: String = "진정한 나"
consecutiveLabel.attributedText = setPartialTextGreen(text: text, targetText: coloredText, attributes: colorAttributes)
} else {
let text: String = "연속 \(self.consecutiveDays)일째 답변 중!"
let text: String = "연속 \(self.consecutiveDays)일째 기록 중!"
consecutiveLabel.attributedText = setNumberTextGreen(text: text, attributes: colorAttributes)
}
}
Expand Down
39 changes: 39 additions & 0 deletions TellingMe/tellingMe/util/managers/AnalyzeManager.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
//
// AnalyzeManager.swift
// tellingMe
//
// Created by KYUBO A. SHIM on 2023/10/06.
//

import UIKit

import FirebaseAnalytics

final class GAManager {
static let shared = GAManager()

private init() {}

enum EventType {
case screen(screenName: String)

var eventName: String {
switch self {
case .screen:
return "screen"
}
}

var parameters: [String: Any]? {
switch self {
case .screen(let screenName):
["screen": screenName]
}
}
}

func logEvent(eventType: EventType) {
Analytics.logEvent(eventType.eventName, parameters: eventType.parameters)
}

}

0 comments on commit e0b1a9e

Please sign in to comment.